Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brial: 1.2.5 -> 1.2.6, pybrial: use brial src #75613

Merged
merged 2 commits into from Dec 13, 2019
Merged

brial: 1.2.5 -> 1.2.6, pybrial: use brial src #75613

merged 2 commits into from Dec 13, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 13, 2019 •
edited

Motivation for this change

Motivation for the update is mostly BRiAl/BRiAl#37, which is a
pre-requiste for getting the sage tests to pass with python3.

The pybrial package is a bit awkward. It doesn't have its own top-level
attribute, since it has a cyclic dependency with sage. That's one of the
reasons why it rarely gets updated. Its distributed along with brial, so
its best to keep the versions synchronized. The easiest way to do this
is to just re-use the source of brial.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
pybrial: 1.2.3 -> 1.2.5, directly use the brial src
6a80092 
The pybrial package is a bit awkward. It doesn't have its own top-level
attribute, since it has a cyclic dependency with sage. That's one of the
reasons why it rarely gets updated. Its distributed along with brial, so
its best to keep the versions synchronized. The easiest way to do this
is to just re-use the source of brial.
@timokau
brial: 1.2.5 -> 1.2.6
135081a 
Motivation is mostly BRiAl/BRiAl#37, which is a
pre-requiste for getting the sage tests to pass with python3.
@timokau timokau merged commit ce013bb into NixOS:master Dec 13, 2019
@timokau timokau deleted the brial-1.2.6 branch December 13, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau