Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amazon-ecs-cli: add darwin #75588

Merged
merged 1 commit into from Dec 16, 2019
Merged

amazon-ecs-cli: add darwin #75588

merged 1 commit into from Dec 16, 2019

Conversation

szg251
Copy link

@szg251 szg251 commented Dec 13, 2019

Motivation for this change

amazon-ecs-cli is not compatible with Mac OS

Things done

Fetching from the correct url on darwin systems.
https://github.com/aws/amazon-ecs-cli

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@szg251
Copy link
Author

szg251 commented Dec 15, 2019

@marsam Thank you for the review!

@szg251 szg251 requested a review from marsam December 16, 2019 02:36
@marsam
Copy link
Contributor

marsam commented Dec 16, 2019

Sorry for the delay, thank you for your contribution. I've made a minor change, I hope you don't mind
@GrahamcOfBorg build amazon-ecs-cli

@marsam marsam merged commit 303c944 into NixOS:master Dec 16, 2019
@szg251
Copy link
Author

szg251 commented Dec 17, 2019

@marsam Not at all! Thank you!
This is my first contribution to Nix, and there are a lot of things I still don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szg251 @marsam @Janik-Haag