Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arp-scan: 1.9.5 -> 1.9.7 #75571

Merged
merged 1 commit into from Dec 13, 2019
Merged

arp-scan: 1.9.5 -> 1.9.7 #75571

merged 1 commit into from Dec 13, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Dec 12, 2019 •
edited

  • 1.9.5 -> 1.9.7
  • Fixes perl shebang and PERL5LIB for get-{oui,iab} scripts
  • Quoted meta.homepage
Motivation for this change

1.9.5 did not seem to work, it didn't give any host list when scanning a local network. upgrading to 1.9.7 fixed the issue for me.

Also fixed PERL5LIB and shebang for helper scripts get-oui and get-iab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor @mikoim

@stigtsp
arp-scan: 1.9.5 -> 1.9.7
31267c1 
- 1.9.5 -> 1.9.7
- Fixes perl shebang and PERL5LIB for get-{oui,iab} scripts
- Quoted meta.homepage
@ofborg ofborg bot requested review from bjornfor and mikoim December 12, 2019 20:38
@bjornfor bjornfor merged commit 5f19aab into NixOS:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@mikoim mikoim Awaiting requested review from mikoim

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @bjornfor