Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling ScaledSpace LateUpdate in LateUpdate BetterLateThanNever induces timing issues #2401

Closed
eggrobin opened this issue Dec 12, 2019 · 0 comments · Fixed by #2402
Closed

Comments

@eggrobin
Copy link
Member

We call the ScaledSpace LateUpdate after reorienting the camera in BetterLateThanNever since #2398.

The things in https://kerbalspaceprogram.com/api/script_order.html that run after ScaledSpace and have a LateUpdate that depends on the position of scaled space are affected.

Notably, this includes Sun, leading to the sun being separated from its lens flare:

screenshot0

It also includes PatchedConicRenderer. While the use case of patched conics in Principia is making fun of stock, I would like not to break things unless we have to (who knows what weird things might depend on patched conics being drawn in the right place).
screenshot1

The easiest way to solve this may be to call the relevant LateUpdates in order after the ScaledSpace one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant