New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: john: disable native tests for john the ripper #75614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixosTests.ipv6: port to python
tdb: 1.3.16 -> 1.3.18
phoronix-test-suite: 9.0.1 -> 9.2.0
libredirect: fix argument forwarding in `open*` functions
Since bash-completion rules are loaded dynamically, the completion rules for `gitk <Tab>` waere not being loaded until the user first typed `git <Tab>`. Fix this by adding a symlink named `gitk`. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Fixes #75075. To summarize the report in the aforementioned issue, at a glance, it's a different default than what upstream polkit has. Apparently for 8+ years polkit defaults admin identities as members of the wheel group [0]. This assumption would be appropriate on NixOS, where every member of group 'wheel' is necessarily privileged. [0]: https://gitlab.freedesktop.org/polkit/polkit/commit/763faf434b445c20ae9529100d3ef5290976d0c9
…mbers python38Packages.phonenumbers: 8.10.23 -> 8.11.0
conmon: v2.0.3 -> v2.0.4
rabbitmq-c: 0.9.0 -> 0.10.0
riemann: 0.3.4 -> 0.3.5
…ialog python38Packages.pythondialog: 3.4.0 -> 3.5.0
python38Packages.shodan: 1.19.1 -> 1.20.0
python38Packages.ipdb: 0.12.2 -> 0.12.3
gitAndTools.tig: 2.4.1 -> 2.5.0
A centralized list for these renames is not good because: - It breaks disabledModules for modules that have a rename defined - Adding/removing renames for a module means having to find them in the central file - Merge conflicts due to multiple people editing the central file
ibm-plex: 4.0.1 -> 4.0.2
pulseeffects: 4.6.8 -> 4.6.9
solr: 8.3.0 -> 8.3.1
Move renames to their appropriate places
scaredmushroom
requested review from
rycee,
thoughtpolice,
ttuegel and
zimbatm
as code owners
December 13, 2019 19:39
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: golang
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: policy discussion
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: steam
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: documentation
8.has: module (update)
2.status: merge conflict
labels
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: golang
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: policy discussion
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: steam
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: documentation
8.has: module (update)
12. first-time contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The default.nix of john has a faulty build flag. Through that john is currently not working.
This problem was fixed in master.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @