Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added softinio to maintainers list #75608

Merged
merged 1 commit into from Dec 14, 2019
Merged

Added softinio to maintainers list #75608

merged 1 commit into from Dec 14, 2019

Conversation

softinio
Copy link
Member

Motivation for this change

In preparation for contributing to Nixpkgs adding myself to the maintainers list

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@softinio
Copy link
Member Author

@NeQuissimus Fancy reviewing/Merging this? Thank you sir. Hope all is well.

@NeQuissimus NeQuissimus merged commit 9a99ca4 into NixOS:master Dec 14, 2019
@softinio softinio deleted the add-softinio-to-maintainers-list branch December 14, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@softinio @NeQuissimus