root: 6.12.06 -> 6.18.04 #75569
root: 6.12.06 -> 6.18.04 #75569
Conversation
Also switch to python3.
There was a problem hiding this comment.
diff LGTM
most executables show usage (didn't test them all)
[6 built (1 failed), 240 copied (194.9 MiB), 70.9 MiB DL]
error: build of '/nix/store/8h475w2jgvbj88svpig8prbyxq6xkiak-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75569
2 package failed to build:
python27Packages.root_numpy python27Packages.rootpy
5 package were built:
fastnlo hepmc3 mcgrid root yoda-with-root
I'll open up a different PR to fix the packages broken on master
builder for '/nix/store/3ljrk9zfagj8zynxicvmz9v8vdfikdli-python2.7-root_numpy-4.8.0.drv' failed with exit code 1; last 10 log lines:
setting SOURCE_DATE_EPOCH to timestamp 1547045302 of file root_numpy-4.8.0/setup.cfg
patching sources
configuring
no configure script, doing nothing
building
Executing setuptoolsBuildPhase
Traceback (most recent call last):
File "nix_run_setup", line 3, in <module>
import setuptools
ImportError: No module named setuptools
|
@GrahamcOfBorg build fastnlo hepmc3 mcgrid root yoda-with-root |
|
darwin timeout due to llvm rebuild |
I appreciate this a lot. However, I think the time has come to remove |
|
no problem :), it was an easy fix. For deprecating the package, feel free to do what you would like :). Python2 is EOL in 2 weeks anyway, I just don't like seeing failure noise in nix-review |
|
Well, I don't know what the plan is. But if it is to just crash all of python2 infrastructure in nixpkgs, then now is the good time to drop these. |
|
it will likely be up to @FRidh as he probably has more insight than I do. My assumption would be to let it ride until a major CVE is announced, then mark it as vulnerable or remove it entirely |
Motivation for this change
To provide a more modern version of ROOT.
cc @yipengsun who pointed out the issue to me
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)