New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
networkmanagerapplet: default to withGnome #75583
networkmanagerapplet: default to withGnome #75583
Conversation
Why do we want this? The motivation isn't really explicit about that. |
@andir I discovered that all of the networkmanager plugins default to withGnome, and you can't even override them in the nixos module anymore. I don't really see much point to turn this off. We have |
Use of aliases: $ rg gnome3.+networkmanagerapplet
pkgs/desktops/pantheon/default.nix
159: inherit (gnome3) networkmanagerapplet;
197: inherit (gnome3) networkmanagerapplet;
pkgs/tools/networking/network-manager/strongswan.nix
13: buildInputs = [ networkmanager strongswanNM libsecret gtk3 gnome3.networkmanagerapplet ];
pkgs/tools/networking/network-manager/vpnc/default.nix
27: ++ stdenv.lib.optionals withGnome [ gtk3 libsecret gnome3.networkmanagerapplet ];
pkgs/tools/networking/network-manager/fortisslvpn/default.nix
28: ++ stdenv.lib.optionals withGnome [ gtk3 libsecret gnome3.networkmanagerapplet ];
pkgs/tools/networking/network-manager/iodine/default.nix
28: ++ stdenv.lib.optionals withGnome [ gtk3 libsecret gnome3.networkmanagerapplet ];
pkgs/tools/networking/network-manager/openvpn/default.nix
28: ++ stdenv.lib.optionals withGnome [ gtk3 libsecret gnome3.networkmanagerapplet ]; |
I don't get why eval didn't fail, we do |
a7b5a2c
to
1eafee5
Compare
This requires us to add gcr to the module.
1eafee5
to
f5081ec
Compare
After some experimentations with commenting out and renaming things and running |
@andir Lmk if you did have an issue with this. |
Motivation for this change
This requires us to add gcr to the module.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @