Fix manylinux packages #75596
Merged
Fix manylinux packages #75596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good improvement, thanks. The let ... in are not needed though. |
gilligan
force-pushed
the
fix-manylinux
branch
from
73e8f11
to
2e6dc7c
Compare
Make sure lib outputs are used where applicable.
gilligan
force-pushed
the
fix-manylinux
branch
from
2e6dc7c
to
369bfe2
Compare
|
Thanks for the fast feedback @FRidh
Sure. Fine with me either way. Just removed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This makes sure that the
liboutput is used whenever available. Working on manylinux support for poetry2nix I noticed problems with missing libraries and realized this was because some of the buildInputs where thebinoutputs and thus patching viaautoPatchelfHookfailed.Things done
Applying lib.getLib` to make sure we get the library outputs as buildInputs. I tested that it actually works with my WIP poetry2nix code.