Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: add feedparser to dependencies #69437

Merged
merged 3 commits into from Nov 29, 2019
Merged

calibre: add feedparser to dependencies #69437

merged 3 commits into from Nov 29, 2019

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

Calibre needs feedparser to fetch news using rss.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

c0bw3b
c0bw3b approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs

Result of nix-review pr 69437 1

1 package were build:
  • calibre

@c0bw3b c0bw3b merged commit 84df543 into NixOS:master Nov 29, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 13, 2020
@dawidsowa @dtzWill
calibre: add feedparser to dependencies (NixOS#69437)
2cf2ff0 
(cherry picked from commit 84df543)
@dawidsowa dawidsowa deleted the calibre branch October 11, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawidsowa @c0bw3b