Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Erlang OTP to 22.1 #69438

Closed
wants to merge 1 commit into from
Closed

Update Erlang OTP to 22.1 #69438

wants to merge 1 commit into from

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Sep 25, 2019 •
edited

Motivation for this change

Update version to newest Erlang release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @the-kenny @sjmackenzie @couchemar @gleber

@couchemar
Copy link
Contributor

Checked on NixOS with nix-review. Also checked Elixir and Erlang binaries

DianaOlympos
DianaOlympos approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@DianaOlympos DianaOlympos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on fedora.

@cw789
Copy link
Contributor

cw789 commented Oct 14, 2019

Is there anything holding this pull request back?
If so, where could I help?

@cw789 cw789 mentioned this pull request Oct 29, 2019
Closed
10 tasks
@cw789 cw789 mentioned this pull request Nov 15, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/70

@cw789
Copy link
Contributor

cw789 commented Nov 19, 2019

Thanks Łukasz. This PR can be closed now.
I've made a newer one to v22.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@couchemar couchemar couchemar approved these changes

@DianaOlympos DianaOlympos DianaOlympos approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hauleth @couchemar @cw789 @nixos-discourse @DianaOlympos @worldofpeace