Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.flit: fix tests and packaging #69546

Merged
merged 2 commits into from Sep 26, 2019
Merged

python3Packages.flit: fix tests and packaging #69546

merged 2 commits into from Sep 26, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 26, 2019 •
edited

Motivation for this change

Noticed during #69433 that we couldn't build a flit package because this package was broken.

For one of the tests, it uses str(exception) which isn't compatible with pytest5

For the flit setup-hook, i needed to add runHook before calling the hooks, otherwise they failed if someone actually used them (e.g. python3Packages.bash_kernel)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm (python3Packages.bash_kernel got fixed)

$ nix build -f . python3Packages.flit python35Packages.flit python36Packages.flit
[43 built, 127 copied (211.5 MiB), 74.5 MiB DL]

nix-review failed on creating the nix-shell "env", because it tried to execute the flitBuildHook

[7 built (1 failed), 20 copied (12.0 MiB), 7.7 MiB DL]
error: build of '/nix/store/p6qdqk77nd6qappspfrz658lq61lm32b-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69546
3 package were build:
python37Packages.bash_kernel python37Packages.flit python37Packages.flitBuildHook

@jonringer jonringer changed the title Fix flit python3Packages.flit: fix tests and packaging Sep 26, 2019
@zimbatm zimbatm merged commit 28af6ac into NixOS:master Sep 26, 2019
@jonringer jonringer deleted the fix-flit branch September 26, 2019 21:59
@jonringer
Copy link
Contributor Author

@Ma27 Needs backport https://gist.github.com/Ma27/09a7f1e5d8f14639e1673f106a56f283

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 28, 2019
Ma27 pushed a commit that referenced this pull request Sep 28, 2019
@jonringer @Ma27
python3Packages.flit: fix tests and packaging (#69546)
ec3e790 
* python3Packages.flit: fix tests

* python: fix flit setup hook

(cherry picked from commit 28af6ac)
@Ma27
Copy link
Member

Ma27 commented Sep 28, 2019

Backported as ec3e790.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @Ma27 @zimbatm