Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic-extlinux-compatible: generate build-time and host-time extlinux builders #69548

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

generic-extlinux-compatible: generate build-time and host-time extlinux builders #69548

wants to merge 1 commit into from

Conversation

illegalprime
Copy link
Member

Motivation for this change

When cross compiling NixOS one cannot build extlinux bootloaders. This change creates a second script called installBootLoaderNative that is able to run on the build platform and does the boot loader install during cross compilation. installBootLoader is still done with the host's package set.

Things done

Tested both versions by making an image for my BeagleBone green and updating it via NixOps (thus creating a new bootloader entry). Not sure if installBootLoaderNative is a good name or not.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dezgeg

matthewbauer
matthewbauer reviewed Sep 27, 2019
View reviewed changes
nixos/modules/system/boot/loader/generic-extlinux-compatible/default.nix
makeInstaller = b: "${b} -g ${toString cfg.configurationLimit} -t ${timeoutStr} -c";
in {
installBootLoader = makeInstaller builder;
installBootLoaderNative = makeInstaller nativeBuilder;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be used somewhere else in NixOS?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@wegank wegank marked this pull request as draft March 20, 2024 15:11
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@dasJ dasJ Awaiting requested review from dasJ dasJ will be requested when the pull request is marked ready for review dasJ is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illegalprime @matthewbauer @ryantm @wegank