python37Packages.pyrsistent: 0.15.2 -> 0.15.4 #69364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (poetry broken on master)
diff LGTM
[5 built (2 failed), 95 copied (42.0 MiB), 10.0 MiB DL]
error: build of '/nix/store/w29gj5b8lww70q0yy3y7izb78lmdhv8a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69364
2 package failed to build:
poetry python27Packages.poetry
2 package were build:
python27Packages.pyrsistent python37Packages.pyrsistent
Some tests are broken on 0.15.2 if used with pytest 5+ as discussed in NixOS#64145. The issue is fixed in tobgu/pyrsistent#175 and released in 0.15.4.
vlaci
force-pushed
the
pyrsistent-0154
branch
from
4a23b51
to
f821319
Compare
|
#68361 for visibility. |
|
@GrahamcOfBorg build poetry python27Packages.pyrsistent python37Packages.pyrsistent |
jonringer
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (python2Packages.poetry is broken on master)
poetry seems to work
[5 built (1 failed), 24 copied (4.7 MiB), 1.2 MiB DL]
error: build of '/nix/store/8k0wnh3dig0j3plss8s8pqv74qjyx1sd-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69364
1 package failed to build:
python27Packages.poetry
3 package were build:
poetry python27Packages.pyrsistent python37Packages.pyrsistent
|
python2Packages.poetry build being fixed #70225 |
jonringer
added
the
9.needs: port to stable
|
technically not from this PR, but build backported and fixed in 20e214b |
|
The fix has been integrated to master: 9d9aa60 There could be a potential conflict with release-19.09 though |
|
there's a large overlap between the two commits, essentially one uses pytest_4 and other pytest_5. |
|
after the rebase, this PR was essentially reduced down to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some tests are broken on 0.15.2 if used with pytest 5+ as discussed
in #64145. The issue is fixed in tobgu/pyrsistent#175 and released in
0.15.4.
As this package is a required dependency to build
poetrythis fix takes use one step closer to be able to build poetry on unstable, however it is not enough as poetry now fails to build with the following error:Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"NOTE poetry and python27Packages.poetry still fails to build./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @desiderius