-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python37Packages.pyrsistent: 0.15.2 -> 0.15.4 #69364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS (poetry broken on master)
diff LGTM
[5 built (2 failed), 95 copied (42.0 MiB), 10.0 MiB DL]
error: build of '/nix/store/w29gj5b8lww70q0yy3y7izb78lmdhv8a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69364
2 package failed to build:
poetry python27Packages.poetry
2 package were build:
python27Packages.pyrsistent python37Packages.pyrsistent
Some tests are broken on 0.15.2 if used with pytest 5+ as discussed in NixOS#64145. The issue is fixed in tobgu/pyrsistent#175 and released in 0.15.4.
4a23b51
to
f821319
Compare
#68361 for visibility. |
@GrahamcOfBorg build poetry python27Packages.pyrsistent python37Packages.pyrsistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS (python2Packages.poetry is broken on master)
poetry seems to work
[5 built (1 failed), 24 copied (4.7 MiB), 1.2 MiB DL]
error: build of '/nix/store/8k0wnh3dig0j3plss8s8pqv74qjyx1sd-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69364
1 package failed to build:
python27Packages.poetry
3 package were build:
poetry python27Packages.pyrsistent python37Packages.pyrsistent
python2Packages.poetry build being fixed #70225 |
technically not from this PR, but build backported and fixed in 20e214b |
The fix has been integrated to master: 9d9aa60 There could be a potential conflict with release-19.09 though |
there's a large overlap between the two commits, essentially one uses pytest_4 and other pytest_5. |
after the rebase, this PR was essentially reduced down to the |
Motivation for this change
Some tests are broken on 0.15.2 if used with pytest 5+ as discussed
in #64145. The issue is fixed in tobgu/pyrsistent#175 and released in
0.15.4.
As this package is a required dependency to build
poetry
this fix takes use one step closer to be able to build poetry on unstable, however it is not enough as poetry now fails to build with the following error:Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
NOTE poetry and python27Packages.poetry still fails to build./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @desiderius