Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gajim: add missing setuptools dependency #69366

Merged
merged 1 commit into from Sep 25, 2019
Merged

gajim: add missing setuptools dependency #69366

merged 1 commit into from Sep 25, 2019

Conversation

erosennin
Copy link
Contributor

Motivation for this change

Gajim crashes because of missing pkg_resources module which part of setuptools:

Traceback (most recent call last):
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/bin/..gajim-wrapped-wrapped", line 11, in <module>
    sys.exit(main())
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/gajim.py", line 123, in main
    _init_gui('GTK')
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/gajim.py", line 49, in _init_gui
    _init_gtk()
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/gajim.py", line 70, in _init_gtk
    from gajim import gtkexcepthook
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/gtkexcepthook.py", line 42, in <module>
    from gajim.common import configpaths
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/common/configpaths.py", line 242, in <module>
    _paths = ConfigPaths()
  File "/nix/store/21glmpkw51vm6pjfw6khj5szl05rczpi-gajim-1.1.3/lib/python3.7/site-packages/gajim/common/configpaths.py", line 131, in __init__
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @raskin @aszlig @abbradar

jonringer
jonringer approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work
leaf package

only criticism is that all of the commands seem to be double wrapped:

$ la ./results/gajim/bin/
..gajim-history-manager-wrapped-wrapped  .gajim-history-manager-wrapped  gajim
..gajim-remote-wrapped-wrapped           .gajim-remote-wrapped           gajim-history-manager
..gajim-wrapped-wrapped                  .gajim-wrapped                  gajim-remote

@7c6f434c
Copy link
Member

Double wrapping doesn't seem a new regression…

@7c6f434c 7c6f434c merged commit aad0efd into NixOS:master Sep 25, 2019
@ajs124
Copy link
Member

ajs124 commented Oct 12, 2019

This (probably) needs backporting to 19.09.

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 12, 2019
@jonringer
Copy link
Contributor

it does

7c6f434c added a commit that referenced this pull request Oct 14, 2019
@7c6f434c
Merge pull request #69366 from erosennin/gajim-setuptools
45a25ff 
gajim: add missing setuptools dependency
(cherry picked from commit aad0efd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@aszlig aszlig Awaiting requested review from aszlig

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erosennin @7c6f434c @ajs124 @jonringer