Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus: set datadir again #69434

Closed
wants to merge 1 commit into from
Closed

dbus: set datadir again #69434

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Fixes #69404

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace added this to the 19.09 milestone Sep 25, 2019
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 25, 2019
@markuskowa
Copy link
Member

Should this be based against staging or master?

ck3d
ck3d approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapper test passes with this patch.

This was referenced Sep 26, 2019
Closed
Closed
@worldofpeace
Copy link
Contributor Author

cc @disassembler @lheckemann

@worldofpeace
Copy link
Contributor Author

Merged to staging-next c8f2427
Merged to staging-19.09 a694217

Staging-next because this fix needs to land quick even if it's a mass rebuild.

@worldofpeace worldofpeace deleted the dbus-datadir-etc-for-real branch September 28, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

nixos/dbus: snapper CLI fails because of failed dbus system-service discovery
3 participants
@worldofpeace @markuskowa @ck3d