Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pastel: init at 0.5.3 #68921

Merged
merged 2 commits into from Sep 25, 2019
Merged

pastel: init at 0.5.3 #68921

merged 2 commits into from Sep 25, 2019

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Sep 16, 2019 •
edited

Motivation for this change

Add a package for pastel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

alexarice
alexarice reviewed Sep 16, 2019
View reviewed changes
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pastel/default.nix Outdated Show resolved Hide resolved
alexarice
alexarice approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with nix-review and runs on nixos

@dtzWill
Copy link
Member

dtzWill commented Sep 23, 2019

What's the relation to #67960? One of these probably should be closed...? :)

@alexarice
Copy link
Contributor

What's the relation to #67960? One of these probably should be closed...? :)

I've managed to review both somehow

@mtrsk
Copy link
Member

mtrsk commented Sep 25, 2019

What's the relation to #67960? One of these probably should be closed...? :)

I can close mine so this one can be merged.

@worldofpeace worldofpeace merged commit 7e36240 into NixOS:master Sep 25, 2019
@worldofpeace
Copy link
Contributor

Thanks for contributing @davidtwco.

Sorry about the PR duplication @mtrsk, this can occasionally happen with how active the nixpkgs contributors are with packaging.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 25, 2019
@worldofpeace @dtzWill
Merge pull request NixOS#68921 from davidtwco/pastel-init
ccc15b0 
pastel: init at 0.5.3
(cherry picked from commit 7e36240)
@mtrsk
Copy link
Member

mtrsk commented Sep 25, 2019

Sorry about the PR duplication @mtrsk, this can occasionally happen with how active the nixpkgs contributors are with packaging.

No prob, I still plan to help the project, especially with broken packages that appear now and then.

@davidtwco davidtwco deleted the pastel-init branch September 26, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@alexarice alexarice alexarice approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidtwco @dtzWill @alexarice @mtrsk @worldofpeace @jonringer