Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cura update #69435

Merged
merged 5 commits into from Sep 26, 2019
Merged

Cura update #69435

merged 5 commits into from Sep 26, 2019

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Sep 25, 2019

Motivation for this change

Version 4.3.0 of the Cura slicer has been released. This change updates the version available in the nixpkgs repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @gebner

@ofborg ofborg bot requested review from gebner and abbradar September 25, 2019 21:10
@gebner
Copy link
Member

gebner commented Sep 26, 2019

Please also update uranium, libarcus, and libsavitar (these are typically released together with cura).

@esclear esclear requested a review from FRidh as a code owner September 26, 2019 08:24
@gebner
Copy link
Member

gebner commented Sep 26, 2019

@GrahamcOfBorg build cura

@gebner
Copy link
Member

gebner commented Sep 26, 2019

Hmm, libarcus is failing. Probably due to this hack: Ultimaker/libArcus@2e9160f

@esclear
Copy link
Contributor Author

esclear commented Sep 26, 2019 •
edited

Oh, I already had the library updates committed when I ran nix-review wip.
I'll try to debug the libarcus build fail.

Okay, I get the following build output from libarcus:

Build output 
  CMake Error at cmake_install.cmake:55 (file):
    file INSTALL cannot copy file "/build/source/build/Arcus.so" to
    "/nix/store/k0igqpz995nmxwf6piyd5jjpcc7gcnyc-python3-3.7.4/lib/python3.7/site-packages/Arcus.so".
I'm new to nixos, so I'm not sure yet, how to fix the problem, although it is not obvious to me, how (or whether at all) the commit you linked and the build fail are related.

Do you have any ideas how to fix it?

@esclear
Copy link
Contributor Author

esclear commented Sep 26, 2019

Okay, I fixed the libarcus build failure.
This should work now.

For future reference:
The sed command I modified probably has to be adjusted for one of the next updates of libarcus:
Ultimaker/libArcus@c3b0028 introduces a change, but this has not landed in the version tagged 4.3.0.

@gebner
Copy link
Member

gebner commented Sep 26, 2019

@GrahamcOfBorg build

@gebner
Copy link
Member

gebner commented Sep 26, 2019

@GrahamcOfBorg build cura

@gebner gebner merged commit 29b0879 into NixOS:master Sep 26, 2019
@gebner gebner mentioned this pull request Oct 15, 2019
Merged
10 tasks
nh2 added a commit to nh2/nixpkgs that referenced this pull request Dec 7, 2019
@nh2
cura, python3Packages.libsavitar, python3Packages.libarcus, python3Pa…
50c8701 
…ckages.uranium: 4.3.0 -> 4.4.0

Closes NixOS#74134.

Note the `cura.materials` hash is not updated because apparently
its contents stay the same, despite version update.

Implements comment about libarcus from:
NixOS#69435 (comment)
@nh2 nh2 mentioned this pull request Dec 7, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

@abbradar abbradar Awaiting requested review from abbradar

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esclear @gebner