Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailspring: init at 1.6.3 #69384

Closed
wants to merge 2 commits into from
Closed

mailspring: init at 1.6.3 #69384

wants to merge 2 commits into from

Conversation

rummik
Copy link
Contributor

@rummik rummik commented Sep 24, 2019

Motivation for this change

I was checking out Mailspring, and happened to find out that there wasn't a Nix package for it. So here's the result after some poking around. It uses more or less the same configuration option that previously existed for Nylas to enable Gnome3's keyring, since libsecret requires a functioning password storage option

I'm not totally sure what else I should do since this is my first time contributing 馃槄

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

You should collaborate with @tyrion who recently opened #69027.

@tyrion
Copy link

tyrion commented Sep 29, 2019

I get this error when trying to build it:

searching for dependencies of /nix/store/jbbzpxz0k7ibhj4hjya7kr91sihifws1-mailspring-1.6.3/share/mailspring/resources/app.asar.unpacked/libscram.so.2.0.25
  libcrypto.so.1.0.0 -> not found!
builder for '/nix/store/v0vp01ppvgkbw0zzciqg8gfc5ya965fg-mailspring-1.6.3.drv' failed with exit code 1
error: build of '/nix/store/v0vp01ppvgkbw0zzciqg8gfc5ya965fg-mailspring-1.6.3.drv' failed

@rummik
Copy link
Contributor Author

rummik commented Sep 29, 2019

@tyrion Yeah, looks like I somehow lost a dependency somewhere

@rummik
Copy link
Contributor Author

rummik commented Sep 29, 2019

@tyrion Seems the updated openssl versions didn't include libcrypto.so.1.0.0, so a symlink was needed. It still requires gnome-keyring to function though, or some other keyring with libsecret support

@aanderse
Copy link
Member

ping (triage)

@aanderse
Copy link
Member

Seems like something went wrong with your last push. Can you please take a look and try again?

@tyrion
Copy link

tyrion commented Oct 16, 2019

Just a note: a new mailspring release happened meanwhile. It may be worth trying it.

@tyrion
Copy link

tyrion commented Oct 22, 2019

I tried this pr and it seemed to work fine in the beginning, but then I realized I had problems with my non-google accounts. For some reason SMTP refuses to work. I tried with mailbox.org and posteo.de. The issue I was getting is similar to this one: Foundry376/Mailspring#341

Switching back to my pr ( #69027 ) the issue seems to vanish.

@toschmidt toschmidt mentioned this pull request Apr 18, 2020
10 tasks
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@tobkratz
Copy link
Contributor

#85492 working better. May wanna close this PR.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2020
@drewrisinger
Copy link
Contributor

Closed by #85492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants