Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: build initrd and modules tree locally #69386

Closed
wants to merge 1 commit into from
Closed

kernel: build initrd and modules tree locally #69386

wants to merge 1 commit into from
+3 −0

Conversation

ivan
Copy link
Member

@ivan ivan commented Sep 24, 2019 •
edited
Loading

Motivation for this change

morph was spending too much time building these remotely. I confirmed that it started building locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice

If accepted, please cherry-pick to 19.09 or let me know you want a backport PR.

Sorry, something went wrong.

@ivan
kernel: build initrd and modules tree locally

Verified

This commit was signed with the committer’s verified signature. The key has expired.
thoughtpolice Austin Seipp
GPG key ID: 25D2038DEB08021D
Expired
Verified
Learn about vigilant mode
f1426ee
@grahamc
Copy link
Member

grahamc commented Sep 24, 2019

I'm not sure. For example, if I'm building a dozen systems worth, it is very worth it to me to build the initrds remotely. Especially since the initrds do take a good bit of resources to compute. I think typically the "prefer local" builds are much more trivial than an initrd.

Not a -1.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 24, 2019
@ivan ivan closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @grahamc