Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-runtime{,_2}: init at 3 and 2.2.7 #69382

Closed
wants to merge 2 commits into from
Closed

dotnet-runtime{,_2}: init at 3 and 2.2.7 #69382

wants to merge 2 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 24, 2019 •
edited

Motivation for this change

https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0/

noticed there was a dotnet-sdk package, but not a runtime package (way smaller size foot-print). So, this is to remedy that issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

# sdk size
$ nix path-info -Sh ./result
/nix/store/89di93ibgvdzykyj4g5xmc4f9i5v6k0k-dotnet-sdk-2.2.401   770.9M
# runtimes
$ nix path-info -Sh ./result
/nix/store/jckkgjkkaacaz21yl5aap2x80xxrnr4z-dotnet-runtime-2.2.7         391.0M
$ nix path-info -Sh ./result
/nix/store/303pc0ibq8k4i837ka56zl7lwhxkh2cm-dotnet-runtime-3.0.0         393.8M

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69382
2 package were build:
dotnet-runtime dotnet-runtime_2

@baracoder baracoder mentioned this pull request Nov 12, 2019
Merged
10 tasks
marsam
marsam reviewed Dec 17, 2019
View reviewed changes
pkgs/development/tools/dotnet/runtime/2.nix

stdenv.mkDerivation rec {
pname = "dotnet-runtime";
version = "2.2.7";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be 2.1? because IIUC 2.1 is a TLS release, and 2.2 is going to reach EOL in December 23, 2019 https://dotnet.microsoft.com/download/dotnet-core. Besides that, LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually considering closing this. #73262 fixes a lot more issues

@jonringer
Copy link
Contributor Author

closing in favor of #73262

@jonringer jonringer closed this Dec 17, 2019
@jonringer jonringer deleted the add-dotnet-runtime branch December 17, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam