zfsStable: don't throw with incompatible kernels #69400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel packages get evaluated because of mergeEqualOption. The current throw prevents from installing 5.3. I replaced it with a warning instead. x:371:8: while evaluating anonymous function at /home/teto/nixpkgs/lib/options.nix:110:23, called from /home/teto/nixpkgs/lib/options.nix:110:10: while evaluating the attribute 'zfsStable' at /home/teto/nixpkgs/pkgs/os-specific/linux/zfs/default.nix:152:3: while evaluating 'common' at /home/teto/nixpkgs/pkgs/os-specific/linux/zfs/default.nix:20:12, called from /home/teto/nixpkgs/pkgs/os-specific/linux/zfs/default.nix:152:15: Linux v5.3 is not yet supported by zfsonlinux v0.8.1. Try zfsUnstable or set the NixOS option boot.zfs.enableUnstable.
|
And you do not have zfs enabled somehow? |
|
I have never used/enabled zfs. To reproduce it should be enough to remove zfs configuration, and set |
|
Still a warning is shown. I wonder if there is a better fix. |
|
Does replacing the |
|
so in my case the error came from libvirtd evaluating it while installing a linux_5_3 so in fact I think the warning was justified, I should just have enabled the unstable one or modified libvirtd to build without zfs (which may be a better long term solution, not everyone needs it with libvirtd). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kernel packages get evaluated because of mergeEqualOption. The current
throw prevents from installing 5.3. I replaced it with a warning
instead.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @