Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-sdk_3: init at 3.0.100 #69392

Closed
wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0/

leaving the previous dotnet-sdk as everything that use the dotnet-clr will likely need it still.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@juselius
Copy link
Contributor

juselius commented Sep 25, 2019

I tested the patch, but building a simple app results in:

Microsoft (R) Build Engine version 16.3.0+0f4c62fea for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Paket version 5.219.5
  The last restore is still up to date. Nothing left to do.
  Performance:
   - Runtime: 76 milliseconds
  Paket version 5.219.5
  Starting restore process.
  Performance:
   - Runtime: 1 second
  Restore completed in 247.95 ms for /home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj.
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018: The "ResolveAssemblyReference" task failed unexpectedly. [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018: System.TypeInitializationException: The type initializer for 'System.Runtime.Serialization.Formatters.Binary.Converter' threw an exception. [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:  ---> System.BadImageFormatException: Could not load file or assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The module was expected to contain an assembly manifest. [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018: File name: 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, RuntimeAssembly assemblyContext, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, AssemblyLoadContext assemblyLoadContext) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, StackCrawlMark& stackMark, AssemblyLoadContext assemblyLoadContext) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Reflection.Assembly.Load(String assemblyString) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Runtime.Serialization.Formatters.Binary.Converter..cctor() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:  [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:  [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    --- End of inner exception stack trace --- [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.GetAssemblyId(WriteObjectInfo objectInfo) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Serialize(Object graph, BinaryFormatterWriter serWriter, Boolean fCheck) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph, Boolean check) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.Tasks.StateFileBase.SerializeCache(String stateFile, TaskLoggingHelper log) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.Tasks.ResolveAssemblyReference.WriteStateFile() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.Tasks.ResolveAssemblyReference.Execute(FileExists fileExists, DirectoryExists directoryExists, GetDirectories getDirectories, GetAssemblyName getAssemblyName, GetAssemblyMetadata getAssemblyMetadata, GetLastWriteTime getLastWriteTime, GetAssemblyRuntimeVersion getRuntimeVersion, GetAssemblyPathInGac getAssemblyPathInGac, IsWinMDFile isWinMDFile, ReadMachineTypeFromPEHeader readMachineTypeFromPEHeader) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.Tasks.ResolveAssemblyReference.Execute() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/cfch923fw25bk6fjgbp6xah5afad8w6d-dotnet-sdk-3.0.100/bin/sdk/3.0.100/Microsoft.Common.CurrentVersion.targets(2106,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]

Build FAILED.

I get the same error with both netcoreapp2.2 and netcoreapp3.0.

I also tried overriding src in the default dotnet-sdk nix expression using the 3.0.100 bundle. Using netcoreapp2.2 it builds the app, but fails to run (missing 2.2 framework). Using netcoreapp3.0 I get:

/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018: The "CreateAppHost" task failed unexpectedly. [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018: System.UnauthorizedAccessException: Access to the path '/home/jonas/src/nix/iso/Gatherer/src/Server/obj/Debug/netcoreapp3.0/Server' is denied. [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:  ---> System.IO.IOException: Permission denied [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    --- End of inner exception stack trace --- [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(String path, FileMode mode, String mapName, Int64 capacity, MemoryMappedFileAccess access) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at System.IO.MemoryMappedFiles.MemoryMappedFile.CreateFromFile(String path) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.NET.HostModel.AppHost.HostWriter.<>c__DisplayClass2_0.<CreateAppHost>g__RewriteAppHost|0() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.NET.HostModel.RetryUtil.RetryOnIOError(Action func) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.NET.HostModel.AppHost.HostWriter.CreateAppHost(String appHostSourceFilePath, String appHostDestinationFilePath, String appBinaryFilePath, Boolean windowsGraphicalUserInterface, String assemblyToCopyResorcesFrom) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.NET.Build.Tasks.CreateAppHost.ExecuteCore() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
/nix/store/4ghyqvqdv9mxbcgigy59hf5fgnj0jd0b-dotnet-sdk-3.0.100/sdk/3.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(370,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/home/jonas/src/nix/iso/Gatherer/src/Server/Server.fsproj]
    0 Warning(s)
    1 Error(s)

The failure of CreateAppHost is perhaps related to #66618 and dotnet/cli#12234?

Under Windows everyting works.

@jonringer
Copy link
Contributor Author

Interesting, I'll take a look at it. Thanks for reviewing @juselius

@jonringer
Copy link
Contributor Author

Is the source open? i would like to debug this

@jonringer
Copy link
Contributor Author

jonringer commented Sep 25, 2019

I was able to build a few sample projects, the only problem is that it's currently limited in the the number of target frameworks that it supports:

./packs/NETStandard.Library.Ref/2.1.0/ref/netstandard2.1/mscorlib.dll
./packs/Microsoft.NETCore.App.Ref/3.0.0/ref/netcoreapp3.0/mscorlib.dll
./sdk/3.0.100/ref/mscorlib.dll
./shared/Microsoft.NETCore.App/3.0.0/mscorlib.dll

@felschr
Copy link
Member

felschr commented Oct 16, 2019

I have the following issue when using dotnet-sdk_3 from this pull request:
https://github.com/dotnet/core-setup/issues/8511

I copied the dotnet installation folder, applied the proposed sudo chmod -R u+w workaround to the copy and ran dotnet build again. It's actually building without errors after doing applying that change.

@jonringer
Copy link
Contributor Author

jonringer commented Oct 16, 2019

The problem is that it just has the newest frameworks, if you have the older v2 frameworks, then it will try to write the frameworks at dotnet restore time to the installation directory.

Since nixpkgs installs at a readonly path, then it doesn't work.

@juselius
Copy link
Contributor

juselius commented Oct 19, 2019

I now have a fully working dotnet-sdk for .NET Core 3.0.100 available at https://github.com/juselius/nixpkgs/blob/dotnet-sdk-3/pkgs/development/compilers/dotnet/sdk/3.nix.

It's a bit of an ugly hack, but it works. The main problem is that dotnet wants copy, and locally modify the "apphost" binary into the obj directory. If apphost is copied with read-only permissions from the store, the build fails since the binary cannot be modified. The solution is to wrap the dotnet binary with a script which points DOTNET_ROOT to a local sdk in $HOME/.dotnet/sdk/${version}, which contains a rw copy of apphost. Everything else is just symlinked to the ro sdk in the store.

I should point out that I have only tested with netcoreapp3.0 and netstandard2.0.

@jonringer
Copy link
Contributor Author

it's unfortunate that's the case, but i guess in most FHS systems, this wouldn't be an issue

@jonringer
Copy link
Contributor Author

the most proper thing would probably be to use makeFHSenv and let it do it's thing in a sandbox

@juselius
Copy link
Contributor

Perhaps. I'm not a super fan of FHSenv, but I can give it a try.

@juselius
Copy link
Contributor

juselius commented Oct 19, 2019

No luck with buildFHSUserEnv. Trying to compile a simple application fails with:

** Message: 18:44:30.259: Requires Linux version >= 3.19 built with CONFIG_USER_NS

** (process:45397): ERROR **: 18:44:30.263: main: unshare: No space left on device
fish: Job 3, “dotnet build” terminated by signal SIGTRAP (Trace or breakpoint trap)

Ref. https://github.com/juselius/nixpkgs/blob/dotnet-sdk-3/pkgs/development/compilers/dotnet/sdk/3-fhs.nix.

@jonringer
Copy link
Contributor Author

interesting... not the error i was expecting to see

@juselius
Copy link
Contributor

I tried building a more substantial project using my homedir hack, and again it failed with permission denied trying to create AppHost. When I copy the whole sdk directory to $HOME/.dotnet/sdk, and run chmod -R u+w on the whole thing it works. Not very nice.

@juselius
Copy link
Contributor

I think FHS is a dead end. Even if we could work past the runtime errors, everything is still installed RO, which causes the CreateAppHost target to fail. I'm starting to think that patching the dotnet sources is the only real option. Here is the latest (fully working) netcore3.0 hack:

https://github.com/juselius/nixpkgs/blob/dotnet-sdk-3/pkgs/development/compilers/dotnet/sdk/3.nix

@jonringer
Copy link
Contributor Author

Copying the entire directory to a tmp directory each invocation is unacceptable to me. There must be another solution.

@juselius
Copy link
Contributor

It seems some of the underlying issues will get fixed in 3.1 (fingers crossed). I'll settle for this solution for now, since it allows me to do my job. But I really dislike the situation.

@jonringer
Copy link
Contributor Author

I think I'll keep this open until 3.1, then bump it. For now I would just use an overlay as I don't feel comfortable with this going into mainline nixpkgs for the time being.

@juselius
Copy link
Contributor

I totally agree. Anyone in need of version 3 can just pop the configs from here.

@felschr
Copy link
Member

felschr commented Oct 21, 2019

I also agree with postponing the SDK release.
But I was just wondering what about an updated version of omnisharp-roslyn in the mean time?

@juselius
Copy link
Contributor

@felschr have you tried updating it? I don't have any experience with omnisharp-roslyn, I'm a F# developer.

@jirkadanek jirkadanek mentioned this pull request Oct 31, 2019
10 tasks
@baracoder
Copy link
Contributor

@juselius @jonringer There is now a preview of 3.1 available. Can you please check if the issues are fixed?
See dotnet/core-setup#8644 and https://devblogs.microsoft.com/dotnet/announcing-net-core-3-1-preview-2/

Another note: Would it make sense to move common code to generic.nix and just set version for the different versions?

@jonringer
Copy link
Contributor Author

I would much rather wait for a stable release instead of adding something, then potentially breaking people when they bump

@kuznero
Copy link
Member

kuznero commented Nov 13, 2019

Hi @jonringer, would you by any chance want to become a maintainer for dotnet in nixpkgs? More specifically these ones:

pkgs/development/compilers/coreclr/default.nix:    maintainers = with maintainers; [ kuznero ];
pkgs/development/compilers/dotnet/sdk/default.nix:      maintainers = with maintainers; [ kuznero ];

I had long moved to a completely different tech stack which is not making me a good maintainer for these packages. Please consider taking it over.

@jonringer
Copy link
Contributor Author

I work at microsoft, so it's likely that I will need to use dotnet soon. I probably will in time.

@prusnak prusnak mentioned this pull request Nov 17, 2019
10 tasks
@erasmas
Copy link

erasmas commented Dec 11, 2019

3.1 has been released a week ago, can we update this PR please?

@jonringer
Copy link
Contributor Author

I'm probably going to close this in favor of #73262, solves the issue of the default installation not being able to install different sdks. I think there was supposed to be a fix in 3.1 to use a local directory, but haven't verified if this is has been fixed

@jonringer
Copy link
Contributor Author

closing in favor of #73262

@jonringer jonringer closed this Dec 17, 2019
@jonringer jonringer deleted the add-dotnet-sdk3 branch December 17, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants