Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kicad: 5.1.2 -> 5.1.4 [WIP] #69389

Closed
wants to merge 102 commits into from
Closed

kicad: 5.1.2 -> 5.1.4 [WIP] #69389

wants to merge 102 commits into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Sep 24, 2019

Motivation for this change

Update kicad to current version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@tokudan
Copy link
Contributor Author

tokudan commented Sep 24, 2019

@GrahamcOfBorg build kicad

@bjornfor
Copy link
Contributor

I think it's more natural for kicad updates to land on master and not staging(-next).

@tokudan
Copy link
Contributor Author

tokudan commented Sep 25, 2019

@bjornfor I agree, but staging-next has some pending updates for kicad and I intend to add at least one more commit, probably tomorrow to fix some issues with the spice simulation.
I have made some progress there, but the spice simulation still causes a segmentation fault.

@veprbl
Copy link
Member

veprbl commented Sep 25, 2019

@GrahamcOfBorg eval

@tokudan
Copy link
Contributor Author

tokudan commented Sep 26, 2019

going to reopen against master, as staging-next is currently broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet