Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsd2dsl: init at 0.4.1 #69487

Merged
merged 1 commit into from Nov 7, 2019
Merged

lsd2dsl: init at 0.4.1 #69487

merged 1 commit into from Nov 7, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 26, 2019

Motivation for this change

lsd2dsl is a decompiler for ABBYY Lingvo’s proprietary dictionaries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/4cqj9g0hpm1q0kkjyzg8ll6nnjsqbza8-lsd2dsl-0.4.1/
/nix/store/4cqj9g0hpm1q0kkjyzg8ll6nnjsqbza8-lsd2dsl-0.4.1	 543.6M

@alexarice
Copy link
Contributor

@GrahamcOfBorg build lsd2dsl

alexarice
alexarice approved these changes Sep 28, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with nix-review on nixos.
Executable seems to run (at least help menu prints)
Diff looks ok to me

@matthewbauer matthewbauer merged commit ca364e6 into NixOS:master Nov 7, 2019
@sikmir sikmir deleted the lsd2dsl branch November 7, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @alexarice @matthewbauer