Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools-build-hook: fix the develop mode #69486

Closed
wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Sep 26, 2019

I have tested with several packages and develop mode would
systematically trigger.

these paths will be fetched (0.02 MiB download, 0.16 MiB unpacked):
/nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source
copying path '/nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source' from 'https://cache.nixos.org'...
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing setuptools-check-hook
Using setuptoolsCheckPhase
Executing setuptoolsShellHook

Usage:
/nix/store/k0igqpz995nmxwf6piyd5jjpcc7gcnyc-python3-3.7.4/bin/python3.7 -m pip [options]

no such option: -e
Finished executing setuptoolsShellHook

There doesn't seem to be a need for eval in the setuptools-build-hook, especially as
other hooks don't have it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

I have tested with several packages and develop mode would
systematically trigger.

these paths will be fetched (0.02 MiB download, 0.16 MiB unpacked):
  /nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source
copying path '/nix/store/j7bms8a3r2pxl31x7nq9hzjzxzkfkwfk-source' from 'https://cache.nixos.org'...
Sourcing python-catch-conflicts-hook.sh
Sourcing python-remove-bin-bytecode-hook.sh
Sourcing setuptools-build-hook
Using setuptoolsBuildPhase
Using setuptoolsShellHook
Sourcing pip-install-hook
Using pipInstallPhase
Sourcing python-imports-check-hook.sh
Using pythonImportsCheckPhase
Sourcing setuptools-check-hook
Using setuptoolsCheckPhase
Executing setuptoolsShellHook

Usage:
  /nix/store/k0igqpz995nmxwf6piyd5jjpcc7gcnyc-python3-3.7.4/bin/python3.7 -m pip <command> [options]

no such option: -e
Finished executing setuptoolsShellHook

There doesn't seem to be a need for eval in the setuptools-build-hook, especially as
other hooks don't have it.
@teto teto requested a review from FRidh as a code owner September 26, 2019 08:42
@FRidh
Copy link
Member

FRidh commented Sep 26, 2019

Fix for this is in staging 5505d2f

@FRidh FRidh closed this Sep 26, 2019
@teto teto deleted the setuptools-hook branch September 26, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants