Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cmd2: 0.9.16 -> 0.9.17 #69484

Merged
merged 1 commit into from Sep 26, 2019
Merged

pythonPackages.cmd2: 0.9.16 -> 0.9.17 #69484

merged 1 commit into from Sep 26, 2019

Conversation

teto
Copy link
Member

@teto teto commented Sep 26, 2019 •
edited

Changelog https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto teto requested a review from FRidh as a code owner September 26, 2019 08:38
@Mic92
Copy link
Member

Mic92 commented Sep 26, 2019

@GrahamcOfBorg build python2Packages.cmd2 python3Packages.cmd2

@teto teto merged commit 7d7bd8a into NixOS:master Sep 26, 2019
@teto teto deleted the cmd2 branch September 26, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @Mic92