Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fflas-ffpack: disable all avx versions by default #69412

Merged
merged 3 commits into from Sep 27, 2019
Merged

fflas-ffpack: disable all avx versions by default #69412

merged 3 commits into from Sep 27, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 25, 2019

Motivation for this change

To fix a transient failure on hydra. See
linbox-team/fflas-ffpack#284 for more details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
fflas-ffpack: disable all avx versions by default
47bdb5f 
To fix a transient failure on hydra. See
linbox-team/fflas-ffpack#284 for more details.
@timokau
fflas-ffpack: add timokau as a maintainer
cc625cf 
I'm interested in this package as a dependency of sage and therefore
would like ofBorg to notify me on changes.
@timokau
Copy link
Member Author

timokau commented Sep 25, 2019

@7c6f434c should we remove fflas-ffpack_1 that you added in 9cb0a7b33d00ac26509a709d947a02efcb781919? There is no current use of it in nixpkgs, you probably added it in some old attempt to get sage running right?

@timokau
fflas-ffpack_1: remove
030d44f 
No longer used in nixpkgs, so we can clean it up.
@ofborg ofborg bot requested a review from 7c6f434c September 25, 2019 09:39
@timokau
Copy link
Member Author

timokau commented Sep 25, 2019

@GrahamcOfBorg build sage

@7c6f434c
Copy link
Member

Yes, if no current use, then please remove. Maybe it was not Sage, but I added it to use as a dependency.

@timokau timokau merged commit 6cf6a22 into NixOS:master Sep 27, 2019
@timokau timokau deleted the fflas-ffpack-avx branch September 27, 2019 10:20
@timokau timokau mentioned this pull request Oct 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @7c6f434c