Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fints: add implicit setuptools dependency #69411

Closed
wants to merge 1 commit into from
Closed

pythonPackages.fints: add implicit setuptools dependency #69411

wants to merge 1 commit into from

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

I've noticed the fints package uses modules from the setuptools package, which is not explicitly referenced in the setup.py.

Things done

Added setuptools to the propagatedBuildInputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh added this to the 19.09 milestone Sep 25, 2019
jonringer
jonringer approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
leaf package

[2 built, 6 copied (3.7 MiB), 0.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69411
1 package were build:
python37Packages.fints

@FRidh
Copy link
Member

FRidh commented Sep 29, 2019

Could you show the stack trace? I don't see any uses of pkg_resources or setuptools.

@elohmeier
Copy link
Contributor Author

Could you show the stack trace? I don't see any uses of pkg_resources or setuptools.

It's actually in bleach, must have overlooked that:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-5ad800947b4b> in <module>
      1 import keyring
----> 2 from fints.client import FinTS3PinTanClient
      3 from datetime import timedelta, datetime
      4 
      5 import logging

/nix/store/9k43i6a1svymld044hc0jaqrdq6jlb6h-python3-3.7.4-env/lib/python3.7/site-packages/fints/client.py in <module>
      8 from enum import Enum
      9 
---> 10 import bleach
     11 from sepaxml import SepaTransfer
     12 

/nix/store/9k43i6a1svymld044hc0jaqrdq6jlb6h-python3-3.7.4-env/lib/python3.7/site-packages/bleach/__init__.py in <module>
      3 from __future__ import unicode_literals
      4 
----> 5 from pkg_resources import parse_version
      6 
      7 from bleach.linkifier import (

ModuleNotFoundError: No module named 'pkg_resources'

@FRidh thanks for checking!

I've created a new PR for bleach.

@elohmeier elohmeier closed this Sep 29, 2019
@elohmeier
Copy link
Contributor Author

#70006

@elohmeier elohmeier deleted the fints branch September 29, 2019 10:44
@elohmeier elohmeier mentioned this pull request Sep 29, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elohmeier @FRidh @jonringer