vlc: Add libssh2 as dependency to support sftp inputs #69394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build vlc |
aanderse
approved these changes
Sep 25, 2019
jonringer
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (1 broken on master)
diff LGTM
executables seem to work ( didn't test sftp use case)
[15 built (1 failed)]
error: build of '/nix/store/9vj45al5adv4491vzxmrjg5sdsphf77y-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69394
1 package are marked as broken and were skipped:
tomahawk
1 package failed to build:
obs-linuxbrowser
12 package were build:
cantata elisa libsForQt5.phonon-backend-vlc vlc libsForQt511.phonon-backend-vlc libsForQt511.vlc megaglest minitube obs-studio phonon-backend-vlc strawberry tribler
bjornfor
approved these changes
Sep 25, 2019
|
I tried to play a stream over Any ideas? Has anyone successfully tested this? |
|
I have successfully used it over the last few days. But I can't check which session-key algorithm is used, at the moment. |
|
Good enough for me. Problem exists between keyboard and chair... just wanted to confirm. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds libssh2 as a dependency to vlc, thus making it possible to watch videos hosted on sftp servers.
I think this is justifiable, since samba is currently a dependency as well.
If not, I'm fine with using a local overlay in my configuration, although I'd prefer not having to build vlc myself on updates.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
No maintainers specified in the .nix file.