Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tensorflow: fix build with CUDA #69509

Closed
wants to merge 1 commit into from
Closed

pythonPackages.tensorflow: fix build with CUDA #69509

wants to merge 1 commit into from
+9 −3

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 26, 2019 •
edited
Loading

Motivation for this change

The Tensorflow package fails to build for two reasons:

  1. The hash for Tensorflow with CUDA support mismatches.
  2. With GCC 8, the build fails with the following error:
/nix/store/b2svf6rl14n8yvfzb6r1yl8snbz1mblp-cudatoolkit-10.0.130-merged/bin/..//include/crt/host_config.h:129:2:
error: #error -- unsupported GNU version! gcc versions later than 7 are not supported!

This change fixes both issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jyp @abbradar

Sorry, something went wrong.

@danieldk
pythonPackages.tensorflow: fix build with CUDA
57e760f 
The Tensorflow package fails to build for two reasons:

1. The hash for Tensorflow with CUDA support mismatches.
2. With GCC 8, the build fails with the following error:

/nix/store/b2svf6rl14n8yvfzb6r1yl8snbz1mblp-cudatoolkit-10.0.130-merged/bin/..//include/crt/host_config.h:129:2:
error: #error -- unsupported GNU version! gcc versions later than 7 are
not supported!

This change fixes both issues.
@danieldk danieldk requested a review from FRidh as a code owner September 26, 2019 11:39
@ofborg ofborg bot requested a review from abbradar September 26, 2019 11:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 26, 2019
@abbradar
Copy link
Member

The hash for Tensorflow with CUDA support mismatches.

Oh no here we go again. I'll run several experiments later, been trying to fix this issue for months.

@abbradar
Copy link
Member

abbradar commented Oct 1, 2019

I found true reason of checksum change to be yet another Bazel quirk, fixed in 280f17c.

@abbradar
Copy link
Member

abbradar commented Oct 2, 2019

I implemented this another way (we use cudatoolkit_joined_cc and environment variable for this): fixed in 46b7933. Still, thanks!

@abbradar abbradar closed this Oct 2, 2019
@alexvorobiev
Copy link
Contributor

I am getting this error trying to build xgboost with CUDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@abbradar abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @abbradar @alexvorobiev