Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml: init at 4.09.0 #68769

Merged
merged 1 commit into from Sep 27, 2019
Merged

ocaml: init at 4.09.0 #68769

merged 1 commit into from Sep 27, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 14, 2019 •
edited

Motivation for this change

Announcement: https://inbox.ocaml.org/caml-list/66833e61-7251-afb6-7154-c69dec487221@inria.fr/T/#u

And for the final version: https://inbox.ocaml.org/caml-list/24c7441e-b1f8-9957-51b7-eecc0999d246@inria.fr/T/#u

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 14, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_09.ocaml

@vbgl
Copy link
Contributor Author

vbgl commented Sep 20, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_09.ocaml

@vbgl vbgl changed the title ocaml: init at 4.09.0+beta2 ocaml: init at 4.09.0 Sep 20, 2019
@vbgl vbgl marked this pull request as ready for review September 20, 2019 05:38
@vbgl vbgl merged commit 4ca445c into NixOS:master Sep 27, 2019
@vbgl vbgl deleted the ocaml-4.09 branch September 27, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl