Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toot: 0.22.0 -> 0.24.0 #69367

Merged
merged 1 commit into from Sep 27, 2019
Merged

toot: 0.22.0 -> 0.24.0 #69367

merged 1 commit into from Sep 27, 2019

Conversation

nocoolnametom
Copy link
Contributor

@nocoolnametom nocoolnametom commented Sep 24, 2019 •
edited

Motivation for this change

Updating Toot to version 0.24.0 which includes the new TUI along with some encoding fixes since its original introduction in 0.23.0. The TUI uses the urwid package.

https://github.com/ihabunek/toot/blob/0.24.0/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): +1778184
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

@nocoolnametom
toot: 0.22.0 -> 0.24.0
ee68859 
Updating Toot to version 0.24.0 which includes the new TUI along with some encoding fixes since its original introduction in 0.23.0.  The TUI uses the `urwid` package.
matthiasbeyer
matthiasbeyer approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@teto
Copy link
Member

teto commented Sep 27, 2019

@GrahamcOfBorg build toot

@teto teto merged commit 56183fb into NixOS:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nocoolnametom @teto @matthiasbeyer