Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP go-1.12: trying to fix build on i686 #69359

Closed
wants to merge 1 commit into from
Closed

WIP go-1.12: trying to fix build on i686 #69359

wants to merge 1 commit into from

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

There seems to be a flakey test for GC that fails on hydra
and is hard to reproduce. This upstream fix looks like it might
be addressing this issue.

I was unable to reproduce the issue locally, so this is a WIP
to test on hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin
go-1.12: trying to fix build on i686
d9f4c0e 
There seems to be a flakey test for GC that fails on hydra
and is hard to reproduce. This upstream fix looks like it might
be addressing this issue.

I was unable to reproduce the issue locally, so this is a WIP
to test on hydra.
@d-goldin d-goldin changed the title go-1.12: trying to fix build on i686 WIP go-1.12: trying to fix build on i686 Sep 24, 2019
@WilliButz
Copy link
Member

@GrahamcOfBorg build pkgsi686Linux.go_1_12

@ofborg ofborg bot requested review from cstrahan, Mic92 and velovix September 24, 2019 15:24
@WilliButz
Copy link
Member

@GrahamcOfBorg build go_1_12

@d-goldin
Copy link
Contributor Author

Hm, so its generally flakey across the architectures and the patch does not seem to fix it so closing for now and will focus on trying to reproduce somehow locally.

@d-goldin d-goldin closed this Sep 24, 2019
@d-goldin d-goldin deleted the fix_go_1_12_gctest branch September 24, 2019 16:10
@d-goldin d-goldin mentioned this pull request Oct 1, 2019
Merged
10 tasks
@d-goldin d-goldin mentioned this pull request Oct 1, 2019
Merged
10 tasks
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Oct 2, 2019
@d-goldin
go_1_12: 1.12.9 -> 1.12.10
aa46781 
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see NixOS#69359
This was referenced Oct 3, 2019
Closed
Closed
Frostman pushed a commit to Frostman/nixpkgs that referenced this pull request Feb 8, 2020
@d-goldin @Frostman
go_1_12: 1.12.9 -> 1.12.10
60f61ee 
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see NixOS#69359

(cherry picked from commit aa46781)
pull bot pushed a commit to Frostman/nixpkgs that referenced this pull request Feb 12, 2020
@d-goldin @pull
go_1_12: 1.12.9 -> 1.12.10
14a18d4 
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see NixOS#69359

(cherry picked from commit aa46781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92

@velovix velovix Awaiting requested review from velovix

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-goldin @WilliButz