Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idrisPackages.heyting-algebra: remove because superseded #69358

Merged
merged 2 commits into from Sep 25, 2019
Merged

idrisPackages.heyting-algebra: remove because superseded #69358

merged 2 commits into from Sep 25, 2019

Conversation

kmein
Copy link
Member

@kmein kmein commented Sep 24, 2019 •
edited

The functionality provided by this package has been added to the Idris contrib library (module Interfaces.Verified).
Therefore identifiers cannot be disambiguated anymore.

Motivation for this change

@NixOS/backports #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @brainrape

idrisPackages.heyting-algebra: mark as broken
7df8575 
The functionality provided by this package has been added to the Idris contrib library (module `Interfaces.Verified`).
Therefore identifiers cannot be disambiguated anymore.
@infinisil
Copy link
Member

The functionality provided by this package has been added to the Idris contrib library (module Interfaces.Verified).
Therefore identifiers cannot be disambiguated anymore.

Can't we just remove the package then?

@ofborg ofborg bot requested a review from brainrake September 24, 2019 15:23
@kmein
Copy link
Member Author

kmein commented Sep 24, 2019

I wasn't sure about people depending on heyting-algebra and not knowing it has been superseded by the Idris libs.

@brainrake
Copy link
Contributor

Shouldn't we remove the package then?

@brainrake
Copy link
Contributor

If people depend on it, they will be using an older version of idris, so they might as well use an old nixpkgs version or copy this package to their project.

@brainrake
Copy link
Contributor

It doesn't look like any packages in nixpkgs depend on this.

@brainrake
Copy link
Contributor

My fondness of Heyting algebras notwithstanding, and given this is in Idris contrib, I think it's fine to remove the package completely - remove this file and the reference to it in idris-modules/default.nix. Or let me know if you don't have time, I'll do it.

@kmein kmein changed the title idrisPackages.heyting-algebra: mark as broken idrisPackages.heyting-algebra: remove because superseded Sep 24, 2019
@kmein kmein force-pushed the idrisPackages.heyting-algebra branch from c35f89e to 8eb0413 Compare September 24, 2019 17:50
@brainrake
Copy link
Contributor

Thanks, looks good to merge. 👍

@globin globin merged commit 0092f2e into NixOS:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@brainrake brainrake Awaiting requested review from brainrake

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmein @infinisil @brainrake @globin