New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use "bash" for dev-shell #3107
Conversation
It would be nice to support more than just bash. I wonder if zsh has something like rcfile? |
Unfortunately zshell does not support the --rcfile arg. Best to hardcode bash here.
also all the phases contain bash-specific code in nixpkgs. |
oops. I wonder if we should not use the We would need a new interface that says that the builder can accept a |
We can't use the builder attribute because that would give us a non-interactive bash. |
Maybe we should copy the |
src/nix/shell.cc
Outdated
@@ -245,7 +245,7 @@ struct CmdDevShell : Common | |||
|
|||
stopProgressBar(); | |||
|
|||
auto shell = getEnv("SHELL", "bash"); | |||
auto shell = "bash"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't compile because it infers the wrong type for shell
(char *
rather than std::string
).
It's quite common to pin nixpkgs using |
5f1c608
to
fb420dc
Compare
Why is this an issue for an interactive shell? I would imagine that it's better to do this than to use |
Closing now that #3565 is merged |
Unfortunately zshell does not support the --rcfile arg. Best to
hardcode bash here. Fixes #2965