Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.xml2rfc: 2.18.0 -> 2.27.1 (and dependency updates) #68802

Closed
wants to merge 7 commits into from

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Sep 14, 2019

Motivation for this change

Fixes build for pythonPackages.{xml2rfc,cairocffi,cairosvg}.
Mark qiskit as broken as it requires significant effor to upgrade and fix.

Things done

xml2rfc successfully converts an XML to a RFC .txt

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg JohnAZoidberg changed the title pythonPackages.xml2rfc: 2.18.0 -> 2.17.1 (and dependency updates) WIP: pythonPackages.xml2rfc: 2.18.0 -> 2.17.1 (and dependency updates) Sep 14, 2019
@ofborg ofborg bot requested review from vcunat and yrashk September 14, 2019 15:21
@JohnAZoidberg JohnAZoidberg changed the title WIP: pythonPackages.xml2rfc: 2.18.0 -> 2.17.1 (and dependency updates) pythonPackages.xml2rfc: 2.18.0 -> 2.17.1 (and dependency updates) Sep 14, 2019
@JohnAZoidberg
Copy link
Member Author

nix-review pr 68802 is successful now and xml2rfc works.

Thanks for checking the commit message, that's fixed, too.

@elohmeier
Copy link
Contributor

That cairocffi update will help a lot with #68361! Thanks :-)

@FRidh FRidh changed the title pythonPackages.xml2rfc: 2.18.0 -> 2.17.1 (and dependency updates) pythonPackages.xml2rfc: 2.18.0 -> 2.27.1 (and dependency updates) Sep 15, 2019
@JohnAZoidberg
Copy link
Member Author

Everything okay? @Pandaman @vcunat @yrashk
It'd be really useful to have in 19.09 as it makes lots of packages build again.

Sadly a few of the packages don't have maintainers :( But the tests all run through fine, so that's good.

@globin
Copy link
Member

globin commented Sep 24, 2019

This PR has conflicts

@JohnAZoidberg
Copy link
Member Author

An update to pythonPackages.cairocffi was already merged in #69256.
Needed to update pythonPackages.weasyprint now.

xml2rfc command still works.

@globin
Copy link
Member

globin commented Sep 25, 2019

Pushed to master with an additional fix

@globin globin closed this Sep 25, 2019
@JohnAZoidberg
Copy link
Member Author

@globin Can you please explain your fix?

-  # ignore failing test cases
+  # excluded test needs the Ahem font
   checkPhase = ''
     runHook preCheck
-    pytest -k 'not test_table_vertical_align and not test_text_overflow_ellipsis and not test_text_overflow_clip'
+    pytest -k 'not test_font_stretch'
     runHook postCheck
   '';

Are the other tests succeeding for you?
On my machine test_font_stretch doesn't fail, but the others do.

@globin
Copy link
Member

globin commented Sep 25, 2019

After that patch everything worked for me

@JohnAZoidberg
Copy link
Member Author

Are you building this derivation?

> nix-instantiate -A python3Packages.weasyprint
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/d06ki3nzbmmwlbrzdk6hpsdvvv6h91zk-python3.7-weasyprint-50.drv

@vcunat
Copy link
Member

vcunat commented Sep 26, 2019

The derivation you mention builds on Hydra and also when I retry it locally.

@JohnAZoidberg JohnAZoidberg deleted the xml2rfc branch September 26, 2019 12:22
@vcunat
Copy link
Member

vcunat commented Sep 26, 2019

19.09 seems the same for me ATM. (I don't know if Robin fixed it or it was OK already.)

@JohnAZoidberg
Copy link
Member Author

Works for me too, now. Must've messed up something before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants