New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.xml2rfc: 2.18.0 -> 2.27.1 (and dependency updates) #68802
Conversation
9f1907b
to
5bb484b
Compare
Thanks for checking the commit message, that's fixed, too. |
That cairocffi update will help a lot with #68361! Thanks :-) |
This PR has conflicts |
5bb484b
to
5542e62
Compare
An update to
|
5542e62
to
2a35746
Compare
Pushed to master with an additional fix |
@globin Can you please explain your fix? - # ignore failing test cases
+ # excluded test needs the Ahem font
checkPhase = ''
runHook preCheck
- pytest -k 'not test_table_vertical_align and not test_text_overflow_ellipsis and not test_text_overflow_clip'
+ pytest -k 'not test_font_stretch'
runHook postCheck
'';
Are the other tests succeeding for you? |
After that patch everything worked for me |
Are you building this derivation?
|
The derivation you mention builds on Hydra and also when I retry it locally. |
19.09 seems the same for me ATM. (I don't know if Robin fixed it or it was OK already.) |
Works for me too, now. Must've messed up something before. |
Motivation for this change
Fixes build for
pythonPackages.{xml2rfc,cairocffi,cairosvg}
.Mark
qiskit
as broken as it requires significant effor to upgrade and fix.Things done
xml2rfc
successfully converts an XML to a RFC.txt
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)