Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPMIView: 2.14.0 --> 2.16.0, fix iKVM console #69406

Merged
merged 4 commits into from Sep 25, 2019
Merged

IPMIView: 2.14.0 --> 2.16.0, fix iKVM console #69406

merged 4 commits into from Sep 25, 2019

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Sep 25, 2019

Motivation for this change

This PR fixes #26650

Things done

First of all package has to be updated because the previous URL is no longer
accessible. As the bundled JRE is newer the build process needed to be adjusted too.

The main problem was that the iKVM related libraries are always loaded
from the current working directory. The bundled wrapper script makes
sure to CD to the package root folder. This is a no-go in nix as the
application writes its settings in the current working directory and the
store is read-only.

Workaround: create a directory in the users home, where the required
binaries are symlinked and is writable for the current user.

There was an additional issue that for some BMCs IPMIView relies on
the bundled stunnel binary to wrap the iKVM traffic in a TLS tunnel.
Therefore it has to be patched to make it executable and the killall
command is needed on the PATH because it is used to terminate the
stunnel process upon exit.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar based on his work on the original issue

László Vaskó added 2 commits September 25, 2019 09:30
IPMIView: fix indentation
96b2c4c
IPMIView: 2.14.0 --> 2.16.0
13cd9e1 
Notes:
 * Previous URL is no longer accesible
 * build has to be adjusted for the updated JRE bundle
László Vaskó added 2 commits September 25, 2019 09:59
IPMIView: fix iKVM console
15b8478 
This commit fixes NixOS#26650

The main problem was that the iKVM related libraries are always loaded
from the current working directory. The bundled wrapper script makes
sure to CD to the package root folder. This is a no-go in nix as the
application writes its settings in the current working directory and the
store is read-only.

Workaround: create a directory in the users home, where the required
binaries are symlinked and is writable for the current user.

There was an additional issue that for some BMCs IPMIView relies on
the bundled `stunnel` binary to wrap the iKVM traffic in a TLS tunnel.
Therefore it has to be patched to make it executable and the `killall`
command is needed on the PATH because it is used to terminate the
`stunnel` process upon exit.
IPMIView: create desktop file
3848206
@Mic92 Mic92 changed the title IPMIView: 2.14.0 --> 2.16.0, fix iKVM console IPMIView: 2.14.0 --> 2.16.0, fix iKVM console Sep 25, 2019
@Mic92 Mic92 merged commit 0802e57 into NixOS:master Sep 25, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 25, 2019 •
edited

also backported:

[detached HEAD 5205e5f] IPMIView: fix indentation
Author: László Vaskó vlaci@balabit.hu
Date: Wed Sep 25 08:51:46 2019 +0200
1 file changed, 33 insertions(+), 33 deletions(-)
rewrite pkgs/applications/misc/ipmiview/default.nix (74%)
Press Enter to continue
[detached HEAD 784940a] IPMIView: 2.14.0 --> 2.16.0
Author: László Vaskó vlaci@balabit.hu
Date: Wed Sep 25 09:07:49 2019 +0200
1 file changed, 12 insertions(+), 8 deletions(-)
Press Enter to continue
[detached HEAD 9a94674] IPMIView: fix iKVM console
Author: László Vaskó vlaci@balabit.hu
Date: Wed Sep 25 09:10:41 2019 +0200
1 file changed, 28 insertions(+), 4 deletions(-)
Press Enter to continue
[detached HEAD b133bff] IPMIView: create desktop file
Author: László Vaskó vlaci@balabit.hu
Date: Wed Sep 25 09:59:02 2019 +0200
1 file changed, 11 insertions(+)

@vlaci vlaci deleted the ipmiview-216 branch July 31, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipmiview: KVM console doesn't work
2 participants
@vlaci @Mic92