Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests linking to non-existing "OWNERS" files #19296

Closed
zcorpan opened this issue Sep 25, 2019 · 1 comment · Fixed by #19315 or #19317
Closed

Tests linking to non-existing "OWNERS" files #19296

zcorpan opened this issue Sep 25, 2019 · 1 comment · Fixed by #19315 or #19317
Labels
payment-request wg-payments

Comments

@zcorpan
Copy link
Member

zcorpan commented Sep 25, 2019

https://github.com/web-platform-tests/wpt/blob/master/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html#L64

cc @marcoscaceres

Either update to META.yml, or remove the note altogether.

$ git grep "/OWNERS"
lint.whitelist:SUPPORT-WRONG-DIR: css/OWNERS
lint.whitelist:SUPPORT-WRONG-DIR: css/*/OWNERS
payment-request/PaymentValidationErrors/retry-shows-error-member-manual.https.html:  and tag one of the <a href="https://github.com/w3c/web-platform-tests/blob/master/payment-request/OWNERS">owners</a>.
payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html:  and tag one of the <a href="https://github.com/w3c/web-platform-tests/blob/master/payment-request/OWNERS">owners</a>.
payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html:  and tag one of the <a href="https://github.com/w3c/web-platform-tests/blob/master/payment-request/OWNERS">owners</a>.
payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html:  and tag one of the <a href="https://github.com/web-platform-tests/wpt/blob/master/payment-request/OWNERS">owners</a>.
payment-request/payment-response/payerdetailschange-updateWith-immediate-manual.https.html:  and tag one of the <a href="https://github.com/web-platform-tests/wpt/blob/master/payment-request/OWNERS">owners</a>.
payment-request/payment-response/payerdetailschange-updateWith-manual.https.html:  and tag one of the <a href="https://github.com/web-platform-tests/wpt/blob/master/payment-request/OWNERS">owners</a>.
payment-request/payment-response/retry-method-manual.https.html:  and tag one of the <a href="https://github.com/w3c/web-platform-tests/blob/master/payment-request/OWNERS">owners</a>.
tools/ci/jobs.py:                  "!.*/OWNERS",
@marcoscaceres marcoscaceres mentioned this issue Sep 26, 2019
Merged
@zcorpan
Copy link
Member Author

zcorpan commented Sep 26, 2019

Found more instances, plus some w3c/web-platform-tests. Will PR.

@zcorpan zcorpan reopened this Sep 26, 2019
zcorpan added a commit that referenced this issue Sep 26, 2019
@zcorpan
Fix more broken links
90ff47c 
Fixes #19296 (again).
@zcorpan zcorpan mentioned this issue Sep 26, 2019
Merged
foolip pushed a commit that referenced this issue Sep 27, 2019
@zcorpan @foolip
Fix more broken links
1cf9e50 
Fixes #19296 (again).
zcorpan added a commit that referenced this issue Oct 10, 2019
@zcorpan
Fix more broken links
ae73f64 
Fixes #19296 (again).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
payment-request wg-payments
Projects
None yet
Milestone
No milestone
1 participant
@zcorpan