Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/memcached: Switch to a system user #69371

Merged
merged 1 commit into from Oct 3, 2019
Merged

nixos/memcached: Switch to a system user #69371

merged 1 commit into from Oct 3, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Sep 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

@dasJ out of curiosity did you consider using DynamicUser with this service?

@dasJ
Copy link
Member Author

dasJ commented Sep 29, 2019

@aanderse I did, and it would work in my setup, but it would break for people using the unix socket because they cannot add users into the memcached group and hence not write the socket

@aanderse
Copy link
Member

aanderse commented Oct 3, 2019

@dasJ right.

@aanderse aanderse merged commit 2448733 into NixOS:master Oct 3, 2019
@dasJ dasJ deleted the memcached-sysuser branch October 12, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @aanderse