-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epson-escpr2: 1.0.29 -> 1.1.1 #69376
Conversation
@furrycatherder and @joachifm because of the last PR #54906 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict Epson is evil and only keeps the latest version of the rpm on their site. So this is going to keep happening and might be worth hosting a mirror or something. Otherwise lgtm.
@furrycatherder: Yeah, I assume so as well. Right now I'm not sure about the repercussions of mirroring it somewhere, but I'll give it a thought. I'm also not aware whether we have any sort of precedent for hosting 3rd party artifacts yet. Main prio was to provide some fix for the 19.09 release. |
@furrycatherder: Btw, are you by any chance able to try this driver out, if you still happen to have such a device? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to download that as well
trying https://download3.ebz.epson.net/dsc/f/03/00/09/02/31/a332507b6398c6e2e007c05477dd6c3d5a8e50eb/epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm from any mirror
898f520
to
0df56f5
Compare
@jonringer: thanks. forgot to update the other parts of the URL. must have tested sth else while in a hurry. should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
leaf package
Ok, now I had a little time to look into the rpm itself. It seems like the thing is under LGPL 2.1, so at least from that angle archiving the rpm somewhere should be fine. What do we think of trust in the case of hosting it in some arbitrary github repo? The rpm is unfortunately not signed, nor are there any checksums published as far as I can see, so it would be hard to establish trust. AUR does epsons site. Debian seems to have an own repo where they manually merge in changes from upstream, but debian also has a different contribution model. I'd think with nixos we should prefer the original source, but here of course the trade-off would be maintenance effort. @furrycatherder; As the maintainer, what do you think (I just now realized you are ma9e)? |
Just FYI - the binary RPM is signed with keys available on SKS, the source archive is unfortunately not;
|
I sent epson (there is a linux-printing@ address provided in the README or so) a mail asking them if they could also sign the source archive, to make it easier for us wrt trust. But I dont have too high hopes. I'd suggest that if the PR is otherwise OK, we should probably merge it, including backport for 19.09, and open a follow-up issue to figure out the mirror part. |
lgtm 👍 |
The build was failing because the source rpm does not exist on epsons servers anymore. Thus bumping it to an existing version https://hydra.nixos.org/build/101990975/nixlog/5
0df56f5
to
e338105
Compare
backported in 8ef6192 |
Motivation for this change
The build was failing because the source rpm does not exist
on epsons servers anymore.
Thus bumping it to an existing version
https://hydra.nixos.org/build/101990975/nixlog/5
Related: #68361
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @Ma9e