Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epson-escpr2: 1.0.29 -> 1.1.1 #69376

Merged
merged 1 commit into from Oct 1, 2019
Merged

epson-escpr2: 1.0.29 -> 1.1.1 #69376

merged 1 commit into from Oct 1, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

The build was failing because the source rpm does not exist
on epsons servers anymore.

Thus bumping it to an existing version
https://hydra.nixos.org/build/101990975/nixlog/5

Related: #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma9e

@d-goldin
Copy link
Contributor Author

@furrycatherder and @joachifm because of the last PR #54906

furrycatherder
furrycatherder approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@furrycatherder furrycatherder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict Epson is evil and only keeps the latest version of the rpm on their site. So this is going to keep happening and might be worth hosting a mirror or something. Otherwise lgtm.

@d-goldin
Copy link
Contributor Author

@furrycatherder: Yeah, I assume so as well. Right now I'm not sure about the repercussions of mirroring it somewhere, but I'll give it a thought. I'm also not aware whether we have any sort of precedent for hosting 3rd party artifacts yet. Main prio was to provide some fix for the 19.09 release.

@d-goldin
Copy link
Contributor Author

@furrycatherder: Btw, are you by any chance able to try this driver out, if you still happen to have such a device?

jonringer
jonringer reviewed Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to download that as well

trying https://download3.ebz.epson.net/dsc/f/03/00/09/02/31/a332507b6398c6e2e007c05477dd6c3d5a8e50eb/epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm from any mirror

@d-goldin
Copy link
Contributor Author

@jonringer: thanks. forgot to update the other parts of the URL. must have tested sth else while in a hurry. should be fine now.

jonringer
jonringer approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
leaf package

@d-goldin
Copy link
Contributor Author

Ok, now I had a little time to look into the rpm itself. It seems like the thing is under LGPL 2.1, so at least from that angle archiving the rpm somewhere should be fine. What do we think of trust in the case of hosting it in some arbitrary github repo? The rpm is unfortunately not signed, nor are there any checksums published as far as I can see, so it would be hard to establish trust.

AUR does epsons site. Debian seems to have an own repo where they manually merge in changes from upstream, but debian also has a different contribution model. I'd think with nixos we should prefer the original source, but here of course the trade-off would be maintenance effort.

@furrycatherder; As the maintainer, what do you think (I just now realized you are ma9e)?

@d-goldin
Copy link
Contributor Author

d-goldin commented Sep 25, 2019 •
edited

Just FYI - the binary RPM is signed with keys available on SKS, the source archive is unfortunately not;

$ rpm -K -v epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm
epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.src.rpm:
    Header SHA1 digest: OK
    MD5 digest: OK

$ rpm -K -v epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.x86_64.rpm
epson-inkjet-printer-escpr2-1.1.1-1lsb3.2.x86_64.rpm:
    Header V4 DSA/SHA1 Signature, key ID 8aa65d56: OK
    Header SHA1 digest: OK
    V4 DSA/SHA1 Signature, key ID 8aa65d56: OK
    MD5 digest: OK

@d-goldin
Copy link
Contributor Author

I sent epson (there is a linux-printing@ address provided in the README or so) a mail asking them if they could also sign the source archive, to make it easier for us wrt trust. But I dont have too high hopes. I'd suggest that if the PR is otherwise OK, we should probably merge it, including backport for 19.09, and open a follow-up issue to figure out the mirror part.

@furrycatherder
Copy link
Contributor

lgtm 👍

@symphorien symphorien mentioned this pull request Sep 30, 2019
Closed
10 tasks
@d-goldin @worldofpeace
epson-escpr2: 1.0.29 -> 1.1.1
e338105 
The build was failing because the source rpm does not exist
on epsons servers anymore.

Thus bumping it to an existing version
https://hydra.nixos.org/build/101990975/nixlog/5
@worldofpeace worldofpeace changed the title epson-escpr2: bumping version to 1.1.1 epson-escpr2: 1.0.29 -> 1.1.1 Oct 1, 2019
@worldofpeace worldofpeace merged commit 1ac5e08 into NixOS:master Oct 1, 2019
@worldofpeace
Copy link
Contributor

backported in 8ef6192

@d-goldin d-goldin deleted the bump-epson-escpr2 branch October 1, 2019 05:57
@d-goldin d-goldin mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@furrycatherder furrycatherder furrycatherder approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-goldin @furrycatherder @worldofpeace @jonringer