thinkfan: 0.9.3 -> 1.0.2 (replaces #55895) #69375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
requested changes
Sep 24, 2019
peterhoeg
reviewed
Sep 24, 2019
peterhoeg
reviewed
Sep 26, 2019
|
|
||
| cmakeFlags = stdenv.lib.optional smartSupport "-DUSE_ATASMART=ON"; | ||
| buildInputs = [ libyamlcpp ] ++ stdenv.lib.optional smartSupport libatasmart; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Last thing, sorry, please do runHook preInstall/postInstall when you are overriding the whole phase.
peterhoeg
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#55895(thinkfan: 0.9.3 -> 1.0.1) wasn't merged due to some remarks and some merge conflicts with master. This PR incorporates the changes from #55895, addresses the remarks and adds an update to 1.0.2.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @domenkozar