Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: 19.1.5 -> 19.2.0 #69537

Merged
merged 1 commit into from Oct 9, 2019
Merged

mesa: 19.1.5 -> 19.2.0 #69537

merged 1 commit into from Oct 9, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Sep 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vcunat
Copy link
Member

vcunat commented Sep 26, 2019

Upstream generally considers every .0 a testing release, but if there's a reason, it might be OK for us to switch early without waiting for .1. (We have stable branches after all.)

@eadwu
Copy link
Member Author

eadwu commented Sep 27, 2019

Main reason for the bump is just for Iris improvements so waiting for .1 is fine though.

@xaverdh
Copy link
Contributor

xaverdh commented Sep 27, 2019

Can iris be used for X/Glamor easily now?

@eadwu
Copy link
Member Author

eadwu commented Sep 27, 2019

Without the environment variable? It depends on the CPU you're using. [1]

[1] https://cgit.freedesktop.org/mesa/mesa/commit/?id=cfbde3282d9b881a8cb09dc7a9c2b25b69872e32&utm_source=anzwix

@xaverdh
Copy link
Contributor

xaverdh commented Sep 27, 2019

Without the environment variable? It depends on the CPU you're using. [1]

[1] https://cgit.freedesktop.org/mesa/mesa/commit/?id=cfbde3282d9b881a8cb09dc7a9c2b25b69872e32&utm_source=anzwix

Ah thanks for the pointer :-)

@jb55
Copy link
Contributor

jb55 commented Sep 29, 2019

@vcunat
Copy link
Member

vcunat commented Sep 29, 2019

llvm9 is in available in nixpkgs master now. I tried to build this PR with it, but I haven't tested these in any other way. I expect we'll want to switch to support these GPUs by default.

@jb55
Copy link
Contributor

jb55 commented Sep 29, 2019

I have tested it. x11/wayland/kmscube doesn't start without llvm9 on navi10 gpus.

@tadfisher
Copy link
Contributor

This breaks SDL2: https://bugzilla.libsdl.org/show_bug.cgi?id=4797

I fixed it here with the following overlay:

  SDL2 = super.SDL2.overrideAttrs (attrs: {
    postPatch = ''
      substituteInPlace include/SDL_opengl_glext.h \
        --replace "typedef ptrdiff_t GLsizeiptr;" "typedef signed long int khronos_ssize_t; typedef khronos_ssize_t GLsizeiptr;" \
        --replace "typedef ptrdiff_t GLintptr;" "typedef signed long int khronos_intptr_t; typedef khronos_intptr_t GLintptr;"
    '';
  });

@jb55
Copy link
Contributor

jb55 commented Oct 9, 2019

looks like there's already a bugfix release for 19.2:

https://lists.freedesktop.org/archives/mesa-announce/2019-October/000548.html

@vcunat vcunat self-assigned this Oct 9, 2019
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can't see what to wait for. (staging)

vcunat added a commit that referenced this pull request Oct 9, 2019
@vcunat vcunat merged commit 2f25cca into NixOS:staging Oct 9, 2019
@jb55
Copy link
Contributor

jb55 commented Oct 9, 2019

ok I'll do a new PR that passes llvm9

@vcunat
Copy link
Member

vcunat commented Oct 9, 2019

@jb55: I did these together, see 53a97c3.

@jb55
Copy link
Contributor

jb55 commented Oct 9, 2019

@vcunat awesome! thanks

@eadwu eadwu deleted the mesa/19.2.0 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants