Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 68.1.0 -> 68.1.1 #69492

Merged
merged 2 commits into from Sep 28, 2019
Merged

thunderbird, thunderbird-bin: 68.1.0 -> 68.1.1 #69492

merged 2 commits into from Sep 28, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 26, 2019

Motivation for this change
  • Bug fixes

https://www.thunderbird.net/en-US/thunderbird/68.1.1/releasenotes/

The release notes mentions “Various security fixes”, but security advisories are not available.
https://www.mozilla.org/en-US/security/known-vulnerabilities/thunderbird/#thunderbird68.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Fuuzetsu, @nbp, @edolstra

@ofborg ofborg bot requested review from nbp and edolstra September 26, 2019 09:58
@alexarice
Copy link
Contributor

Built both of these with nix-review, started thunderbird and that seems to work fine, however when I started thunderbird-bin it complained that my profile had been setup by a newer version. Shouldn't these both be the same version?

On a side note, can I revert this in any way, I want to use installed thunderbird again

@taku0
Copy link
Contributor Author

taku0 commented Sep 27, 2019

Try --allow-downgrade option on startup.

@taku0
Copy link
Contributor Author

taku0 commented Sep 27, 2019

The Security Advisory is updated. It is a moderate security fix.
https://www.mozilla.org/en-US/security/advisories/mfsa2019-32/

@vcunat
Copy link
Member

vcunat commented Sep 28, 2019

I noticed even before this bump that there's apparently something wrong in the way they compare version of -bin and non-bin.

vcunat
vcunat approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work fine.

vcunat added a commit that referenced this pull request Sep 28, 2019
@vcunat
Merge #69492: thunderbird*: 68.1.0 -> 68.1.1
a005d2e
@vcunat vcunat merged commit a3f9b8c into NixOS:master Sep 28, 2019
vcunat added a commit that referenced this pull request Sep 28, 2019
@vcunat
Merge #69492: thunderbird*: 68.1.0 -> 68.1.1
f97286b 
(cherry picked from commit a005d2e)
Re-tested both on 19.09.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @alexarice @vcunat