Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: 1.4.6 -> 1.8.4 #69571

Merged
merged 3 commits into from Nov 17, 2019
Merged

apt: 1.4.6 -> 1.8.4 #69571

merged 3 commits into from Nov 17, 2019

Conversation

georgyo
Copy link
Contributor

@georgyo georgyo commented Sep 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/p8dkrms4nijj7gvcvfk9v2hm1acv2kcd-apt-1.4.6	  136146232
/nix/store/h9zk42aqcab4z2gj1j2hy9gy8vbfz6hn-apt-1.8.4	  148277800
Notify maintainers

cc @

@ofborg ofborg bot requested a review from cstrahan September 26, 2019 19:17
jonringer
jonringer reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i seem to just get seg faults...

[nix-shell:~/.cache/nix-review/pr-69571]$ ./results/apt/bin/apt
Segmentation fault

[nix-shell:~/.cache/nix-review/pr-69571]$ ./results/apt/bin/apt-config
Segmentation fault
Partial strace of apt 
fstat(3, {st_mode=S_IFREG|0555, st_size=78824, ...}) = 0
mmap(NULL, 76840, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e79a000
mmap(0x7f252e79c000, 53248, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7f252e79c000
mmap(0x7f252e7a9000, 8192, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0xf000) = 0x7f252e7a9000
mmap(0x7f252e7ab000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x10000) = 0x7f252e7ab000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/liblzma.so.5", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/62ar9xmrlcnlgmwgfi77xz6bq1180vhi-zlib-1.2.11/lib/liblzma.so.5", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/liblzma.so.5", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20E\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=182544, ...}) = 0
mmap(NULL, 167952, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e770000
mprotect(0x7f252e774000, 147456, PROT_NONE) = 0
mmap(0x7f252e774000, 98304, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x4000) = 0x7f252e774000
mmap(0x7f252e78c000, 45056, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1c000) = 0x7f252e78c000
mmap(0x7f252e798000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x27000) = 0x7f252e798000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/liblz4.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/62ar9xmrlcnlgmwgfi77xz6bq1180vhi-zlib-1.2.11/lib/liblz4.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/liblz4.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/5dn03xfw3wimm78nfpg67p1zj1025sbc-bzip2-1.0.6.0.1/lib/liblz4.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/i945gbylyzlz5gcdsj81vfbaz9yji37w-lz4-1.9.1/lib/liblz4.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\2602\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=215336, ...}) = 0
mmap(NULL, 208912, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e73c000
mmap(0x7f252e73f000, 180224, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x3000) = 0x7f252e73f000
mmap(0x7f252e76b000, 12288, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2f000) = 0x7f252e76b000
mmap(0x7f252e76e000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x31000) = 0x7f252e76e000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/62ar9xmrlcnlgmwgfi77xz6bq1180vhi-zlib-1.2.11/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/5dn03xfw3wimm78nfpg67p1zj1025sbc-bzip2-1.0.6.0.1/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/i945gbylyzlz5gcdsj81vfbaz9yji37w-lz4-1.9.1/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jq6j4imhyq0mmn23lsd39q6zbylyxsrz-zstd-1.4.3/lib/libzstd.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\220W\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=693456, ...}) = 0
mmap(NULL, 667712, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e698000
mprotect(0x7f252e69d000, 643072, PROT_NONE) = 0
mmap(0x7f252e69d000, 585728, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x5000) = 0x7f252e69d000
mmap(0x7f252e72c000, 53248, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x94000) = 0x7f252e72c000
mmap(0x7f252e73a000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0xa1000) = 0x7f252e73a000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/62ar9xmrlcnlgmwgfi77xz6bq1180vhi-zlib-1.2.11/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/5dn03xfw3wimm78nfpg67p1zj1025sbc-bzip2-1.0.6.0.1/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/i945gbylyzlz5gcdsj81vfbaz9yji37w-lz4-1.9.1/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jq6j4imhyq0mmn23lsd39q6zbylyxsrz-zstd-1.4.3/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/sc3wwzzy17xnzm2d9m5ydv098k6c2vy6-systemd-243-lib/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0`X\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=238984, ...}) = 0
mmap(NULL, 198904, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e667000
mprotect(0x7f252e66c000, 172032, PROT_NONE) = 0
mmap(0x7f252e66c000, 122880, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x5000) = 0x7f252e66c000
mmap(0x7f252e68a000, 45056, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x23000) = 0x7f252e68a000
mmap(0x7f252e696000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2e000) = 0x7f252e696000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/62ar9xmrlcnlgmwgfi77xz6bq1180vhi-zlib-1.2.11/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/5dn03xfw3wimm78nfpg67p1zj1025sbc-bzip2-1.0.6.0.1/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/i945gbylyzlz5gcdsj81vfbaz9yji37w-lz4-1.9.1/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jq6j4imhyq0mmn23lsd39q6zbylyxsrz-zstd-1.4.3/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/sc3wwzzy17xnzm2d9m5ydv098k6c2vy6-systemd-243-lib/lib/libsystemd.so.0", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0p9\1\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0444, st_size=889984, ...}) = 0
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f252e665000
mmap(NULL, 758512, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e5ab000
mmap(0x7f252e5bd000, 491520, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x12000) = 0x7f252e5bd000
mmap(0x7f252e635000, 172032, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x8a000) = 0x7f252e635000
mmap(0x7f252e65f000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0xb3000) = 0x7f252e65f000
mmap(0x7f252e664000, 752, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f252e664000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/librt.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/6yaj6n8l925xxfbcd65gzqx3dz7idrnn-glibc-2.27/lib/librt.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\240#\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=45848, ...}) = 0
mmap(NULL, 39424, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e5a1000
mmap(0x7f252e5a3000, 16384, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7f252e5a3000
mmap(0x7f252e5a7000, 8192, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x6000) = 0x7f252e5a7000
mmap(0x7f252e5a9000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x7000) = 0x7f252e5a9000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/haswell/x86_64/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/haswell/x86_64", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/haswell/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/haswell", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/x86_64/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/x86_64", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/tls", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/haswell/x86_64/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/haswell/x86_64", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/haswell/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/haswell", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/x86_64/libcap.so.2", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/x86_64", 0x7ffd04cecc80) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/libcap.so.2", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\20\"\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0444, st_size=26064, ...}) = 0
mmap(NULL, 24920, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e59a000
mmap(0x7f252e59c000, 8192, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7f252e59c000
mmap(0x7f252e59e000, 4096, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x4000) = 0x7f252e59e000
mmap(0x7f252e59f000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x4000) = 0x7f252e59f000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/0m9rsg8dqsr7pq0i42qr6in8lfrqqyvn-libcap-2.27-lib/lib/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/yk8lp0x7sml42gaf9gfkr6cwx99glz7b-xz-5.2.4/lib/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/i945gbylyzlz5gcdsj81vfbaz9yji37w-lz4-1.9.1/lib/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/haswell/x86_64/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/haswell/x86_64", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/haswell/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/haswell", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/x86_64/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/x86_64", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/tls", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/haswell/x86_64/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/haswell/x86_64", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/haswell/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/haswell", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/x86_64/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/x86_64", 0x7ffd04cecc50) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/pdpgm7h0mcbc9xidn0x1xyzcbqdzn2ad-libgcrypt-1.8.5/lib/libgcrypt.so.20", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200\325\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=1258912, ...}) = 0
mmap(NULL, 1175496, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e47b000
mmap(0x7f252e488000, 843776, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0xd000) = 0x7f252e488000
mmap(0x7f252e556000, 249856, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0xdb000) = 0x7f252e556000
mmap(0x7f252e593000, 28672, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x117000) = 0x7f252e593000
close(3)                                = 0
openat(AT_FDCWD, "/run/opengl-driver/lib/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f252e479000
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/haswell/x86_64/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/haswell/x86_64", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/haswell/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/haswell", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/x86_64/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/x86_64", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/tls", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/haswell/x86_64/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/haswell/x86_64", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/haswell/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/haswell", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/x86_64/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
stat("/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/x86_64", 0x7ffd04cecc20) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/q8796x08wb1cmzqg5b6mx6k1k0kcxp8i-libgpg-error-1.36/lib/libgpg-error.so.0", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\200V\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=163816, ...}) = 0
mmap(NULL, 143968, PROT_READ, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f252e455000
mprotect(0x7f252e45a000, 118784, PROT_NONE) = 0
mmap(0x7f252e45a000, 77824, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x5000) = 0x7f252e45a000
mmap(0x7f252e46d000, 36864, PROT_READ, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x18000) = 0x7f252e46d000
mmap(0x7f252e477000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x21000) = 0x7f252e477000
close(3)                                = 0
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f252e453000
mmap(NULL, 12288, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f252e450000
arch_prctl(ARCH_SET_FS, 0x7f252e450840) = 0
mprotect(0x7f252e9c0000, 16384, PROT_READ) = 0
mprotect(0x7f252e477000, 4096, PROT_READ) = 0
mprotect(0x7f252e593000, 8192, PROT_READ) = 0
mprotect(0x7f252e59f000, 4096, PROT_READ) = 0
mprotect(0x7f252e7e9000, 4096, PROT_READ) = 0
mprotect(0x7f252e5a9000, 4096, PROT_READ) = 0
mprotect(0x7f252e798000, 4096, PROT_READ) = 0
mprotect(0x7f252e76e000, 4096, PROT_READ) = 0
mprotect(0x7f252e65f000, 16384, PROT_READ) = 0
mprotect(0x7f252e696000, 4096, PROT_READ) = 0
mprotect(0x7f252e73a000, 4096, PROT_READ) = 0
mprotect(0x7f252e7ab000, 4096, PROT_READ) = 0
mprotect(0x7f252e7ca000, 4096, PROT_READ) = 0
mprotect(0x7f252e804000, 4096, PROT_READ) = 0
mprotect(0x7f252e80b000, 4096, PROT_READ) = 0
mprotect(0x7f252e810000, 4096, PROT_READ) = 0
mprotect(0x7f252ed74000, 4096, PROT_READ) = 0
mprotect(0x7f252eee9000, 49152, PROT_READ) = 0
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x4f4b6} ---
+++ killed by SIGSEGV +++
Segmentation fault

@georgyo
Copy link
Contributor Author

georgyo commented Sep 26, 2019 •
edited

I cannot reproduce your segfaults on nixos, debian, or archlinux. Do you get them with the old version as well?

[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt --version"
apt 1.8.4 (amd64)
E: Unable to determine a suitable packaging system type

[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt"
E: Unable to determine a suitable packaging system type

[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt-config"
E: Unable to determine a suitable packaging system type

@jonringer
Copy link
Contributor

I just get the

E: Unable to determine a suitable packaging system type

using the current master

@georgyo
Copy link
Contributor Author

georgyo commented Oct 1, 2019

Odd... I don't know how to replicate your failure with 1.8.4 here. Nor do I understand what would make something work for me and not you here. We should be loading the same exact libraries, and I am using this in several different environments.

Can you shed some information on your test machine?

@jonringer
Copy link
Contributor

at work I get

[nix-shell:~/.cache/nix-review/pr-69571-2]$ ./results/apt/bin/apt --help
E: Unable to determine a suitable packaging system type

This may be from issues with a sandbox environment at my home computer, and not actually related to this PR :(

@c0bw3b
apt: cleanup
c426608 
* add meta.description and point meta.homepage to Debian team
* use nix cmakeFlags array
* fetch from Debian mirrors
* move gtest and xsltproc to nativeBuildInputs
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2019

I'm getting segfaults with all binaries too ... :/ in a x86-64 NixOS VM

@c0bw3b
apt: produce usable binaries
2c7ff92 
* remove ninja from native build inputs and build with plain cmake
* add libtasn1 to dependencies as gnutls needs it
c0bw3b
c0bw3b approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 69571 1

1 package were build:
  • apt
$ /nix/store/3cjlk16kx0bqxzmi76i1gaipj9fcnmdv-apt-1.8.4/bin/apt --version
apt 1.8.4 (amd64)
E: Unable to determine a suitable packaging system type

$ /nix/store/3cjlk16kx0bqxzmi76i1gaipj9fcnmdv-apt-1.8.4/bin/apt-get --version
apt 1.8.4 (amd64)
Supported modules:
 Ver: Standard .deb
 Pkg:  Debian dpkg interface (Priority 0)
 Pkg:  Debian APT solver interface (Priority -1000)
 Pkg:  Debian APT planner interface (Priority -1000)
 S.L: 'deb' Debian binary tree
 S.L: 'deb-src' Debian source tree
 Idx: Debian Source Index
 Idx: Debian Package Index
 Idx: Debian Translation Index
 Idx: Debian dpkg status file
 Idx: Debian deb file
 Idx: Debian dsc file
 Idx: Debian control file
 Idx: EDSP scenario file
 Idx: EIPP scenario file
E: Unable to determine a suitable packaging system type

@c0bw3b c0bw3b merged commit 6c45ecf into NixOS:master Nov 17, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 17, 2019
@georgyo @dtzWill
apt: 1.4.6 -> 1.8.4
05cc227 
apt: 1.4.6 -> 1.8.4 (NixOS#69571)

apt: cleanup
* add meta.description and point meta.homepage to Debian team
* use nix cmakeFlags array
* fetch from Debian mirrors
* move gtest and xsltproc to nativeBuildInputs

apt: produce usable binaries
* remove ninja from native build inputs and build with plain cmake
* add libtasn1 to dependencies as gnutls needs it

(cherry picked from commit 6c45ecf)
@OPNA2608 OPNA2608 mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgyo @jonringer @c0bw3b