Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peek: 1.3.1 -> 1.4.0 #69403

Merged
merged 3 commits into from Sep 26, 2019
Merged

peek: 1.3.1 -> 1.4.0 #69403

merged 3 commits into from Sep 26, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

See commit messages.

Note that c5df3a6 doesn't actually force gifski post-processing, it's still an option you have to enable in the preferences dialog.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
peek: 1.3.1 -> 1.4.0
f5867c3 
* build with meson
* add gstreamer deps
  Needed for recording in GNOME shell
@worldofpeace
gifski: 0.8.7 -> 0.9.1
f9edafb
@worldofpeace
peek: add gifski support
c5df3a6 
This is an optional feature for gif post-processing.
It produces much better quality gif.

Also added which to PATH with the wrapper, as it's
needed to check for these types of programs [0].

[0]: https://github.com/phw/peek/blob/8b48e8847ad6e1c09fde12972b917bc975153c9c/src/utils.vala#L57
@ofborg ofborg bot requested review from puffnfresh and marsam September 25, 2019 07:27
@worldofpeace worldofpeace mentioned this pull request Sep 25, 2019
Merged
@worldofpeace worldofpeace merged commit 1dc0dcf into NixOS:master Sep 26, 2019
@worldofpeace worldofpeace deleted the peek/update branch September 26, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @marsam