Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset unused variables in setup.sh #69603

Merged
merged 1 commit into from Nov 5, 2019
Merged

Unset unused variables in setup.sh #69603

merged 1 commit into from Nov 5, 2019

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
generic/setup.sh: Unset locally defined variables
1601a7f 
setup.sh adds a bunch of variables that only it needs. To avoid
polluting environments, we should unset these as soon as we are done
with them.
@matthewbauer matthewbauer changed the title Unset unused setup var Unset unused variables in setup.sh Sep 26, 2019
@matthewbauer matthewbauer merged commit 9ffedfe into NixOS:staging Nov 5, 2019
@Ericson2314
Copy link
Member

Ooops, I meant to approve this.

@kirelagin
Copy link
Member

kirelagin commented Nov 5, 2019 •
edited

Staging currently fails with

/nix/store/ds5jk67vpshc666c1jfbi8qx90awmqj3-bootstrap-stage0-stdenv-linux/setup: line 1141: propagatedBuildDepFiles[@]: unbound variable
builder for '/nix/store/z5840d089rn4nni3l0iaybyvm98489zi-bootstrap-stage1-gcc-wrapper.drv' failed with exit code 1

something tells me this might be somehow related :suspicious:

@Ericson2314
Copy link
Member

Ericson2314 commented Nov 5, 2019 •
edited

That is probably something with my set -uing, too. Will fix.

@Ericson2314
Copy link
Member

Ericson2314 commented Nov 5, 2019 •
edited

Ah no it is legit undef problem

@Ericson2314
Copy link
Member

Ericson2314 commented Nov 5, 2019 •
edited

Fixed in 5b6da99. Sorry I didn't catch this pre-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @Ericson2314 @kirelagin