Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solo-python: init at 0.0.15 #69433

Merged
merged 1 commit into from Oct 12, 2019
Merged

solo-python: init at 0.0.15 #69433

merged 1 commit into from Oct 12, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Sep 25, 2019

Support for solokeys U2F tokens

Motivation for this change

I got one of these tokens and wanted to tinker around with it. Unfortunately, their tool was not part of nixpkgs yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wucke13 wucke13 requested a review from FRidh as a code owner September 25, 2019 20:29
@wucke13 wucke13 force-pushed the solokey branch 2 times, most recently from cfb2327 to 1a10dd3 Compare September 25, 2019 20:36
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.solo-python

@wucke13 wucke13 force-pushed the solokey branch 2 times, most recently from d9a20c3 to 5299f82 Compare September 26, 2019 23:14
@wucke13
Copy link
Contributor Author

wucke13 commented Sep 26, 2019

@jonringer
Please review one last time, I removed some temporary attempts at working around the failing tests.

jonringer
jonringer reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry a few more things i noticed :)

pkgs/top-level/python-packages.nix Show resolved Hide resolved
pkgs/development/python-modules/solo-python/default.nix Show resolved Hide resolved
pkgs/development/python-modules/solo-python/default.nix Show resolved Hide resolved
wucke13
wucke13 commented Sep 27, 2019
View reviewed changes
Copy link
Contributor Author

@wucke13 wucke13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer
Thank you again. I adjusted accordingly.

@Lassulus
Copy link
Member

sadly I'm getting this error with nix-review

builder for '/nix/store/hya7zmkwyawgmx21m50npnm9kczxzwfz-python3.7-solo-python-0.0.15.drv' failed with exit code 1; last 10 log lines:
  Writing the record of files                                         I-flit.wheel
  Built wheel: dist/solo_python-0.0.15-py3-none-any.whl               I-flit.wheel
  Finished executing flitBuildPhase
  installing
  Executing pipInstallPhase
  /build/source/dist /build/source
  Processing ./solo_python-0.0.15-py3-none-any.whl
  Collecting fido2==0.7.0 (from solo-python==0.0.15)
    ERROR: Could not find a version that satisfies the requirement fido2==0.7.0 (from solo-python==0.0.15) (from versions: none)
  ERROR: No matching distribution found for fido2==0.7.0 (from solo-python==0.0.15)
cannot build derivation '/nix/store/iczzaacb54v3zzf6z3368rh4sb5dk3bv-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/iczzaacb54v3zzf6z3368rh4sb5dk3bv-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69433
1 package failed to build:
python37Packages.solo-python

@wucke13
solo-python: init at 0.0.15
7a5edf0 
Support for solokeys U2F tokens
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 11, 2019

@Lassulus Fixed that. Also opened an issue with upstream regarding their hard version pinpoint.
Btw.: would you be ok if I tag you on my future PRs? Sometimes things take longer than they should, and I'm somewhat desperate on how to attract people with merge access to my PRs.

@jonringer
Copy link
Contributor

We had the 19.09 release, and 2 rounds of the bot updates, i think there's been ~2000 PRs in the past 2 weeks

Lassulus
Lassulus approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started the python interpreter, imported solo.

@Lassulus Lassulus merged commit 348fac7 into NixOS:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@Lassulus Lassulus Lassulus approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wucke13 @jonringer @Lassulus