teamspeak-client: fix stuck build #69431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4dM4n
force-pushed
the
teamspeak-client-build
branch
2 times, most recently
from
28d9aad
to
7ddc19b
Compare
|
How can I reproduce the failure from |
|
nix-daemon --daemon
\_ nix-daemon 31711
\_ bash -e /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh
\_ sh -xe /nix/store/wkia500ys2xqb0rih7n4vnhnfy1px2h4-TeamSpeak3-Client-linux_amd64-3.3.0.run
\_ sh -xe /nix/store/wkia500ys2xqb0rih7n4vnhnfy1px2h4-TeamSpeak3-Client-linux_amd64-3.3.0.run
\_ lessI'm currently running: # nix run nixpkgs.nix-info -c nix-info -m
- system: `"x86_64-linux"`
- host os: `Linux 5.2.13, NixOS, 19.09pre192418.e19054ab3cd (Loris)`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.3`
- channels(root): `"nixos-20.03pre193829.f0fec244ca3"`
- channels(fabian): `"nixos-19.09pre192418.e19054ab3cd"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos` |
|
Hm weird, works for me. Anyways since this fixes it for you then I'll be happy to merge |
cleverca22
added
the
9.needs: port to stable
|
i suspect its related to a newer #73485 will backport it to 19.09, which was forked while things where broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
teamspeak-clientbuild gets stuck waiting for user input. When the installer gets executed viaecho -e 'q\ny' | sh -xe $src, it displays the license to the user throughless, which doesn't receive theqproperly and stays alive.To not modify the installer the
lesscommand will be replaced by a script that only callscatto output the license.Shortly after pushing this I realized there was areadbefore thelesscommand in the installer, so a missing\nwas all it took to fix the build.Turns out, the first try was the correct fix and using overlays while testing is a bad idea (need to figure out how to disable them temporarily).
Fixes #69415
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"(no depend pkgs)./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @nathanielbaxter