Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-trezor: 0.11.4 -> 0.11.5 #69545

Merged
merged 1 commit into from Sep 26, 2019
Merged

python-trezor: 0.11.4 -> 0.11.5 #69545

merged 1 commit into from Sep 26, 2019

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Sep 26, 2019 •
edited

Motivation for this change

Bump version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @prusnak

@1000101 1000101 requested a review from FRidh as a code owner September 26, 2019 15:50
jonringer
jonringer approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[7 built, 91 copied (213.6 MiB), 50.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69545
5 package were build:
electron-cash electrum python37Packages.keepkey python37Packages.trezor python37Packages.trezor_agent

pkgs/development/python-modules/trezor/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested review from prusnak, mmahut and np September 26, 2019 16:16
@mmahut
Copy link
Member

mmahut commented Sep 26, 2019

@GrahamcOfBorg build python37Packages.trezor

@mmahut mmahut merged commit 54393c4 into NixOS:master Sep 26, 2019
@1000101 1000101 deleted the python-trezor branch September 27, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@prusnak prusnak Awaiting requested review from prusnak

@mmahut mmahut Awaiting requested review from mmahut

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1000101 @mmahut @jonringer